hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aajisaka <...@git.apache.org>
Subject [GitHub] hadoop pull request: HADOOP-12984. Add GenericTestUtils.getTestDir...
Date Mon, 04 Apr 2016 07:12:59 GMT
Github user aajisaka commented on the pull request:

    https://github.com/apache/hadoop/pull/89#issuecomment-205168263
  
    Thank you for rebasing! Mostly looks good to me. Two comments:
    * Can we separate the patch into common change and hdfs change? That way the patch becomes
smaller and the review becomes easier.
    * I'm thinking we should replace not only `test.build.data` but also `test.build.dir`
with `GenericTestUtils.getTestDir`. I'm okay with doing this by separate jira(s).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message