hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From makefu <...@git.apache.org>
Subject [GitHub] hadoop pull request: Shell.java: fix absolute path `/bin/ls`
Date Mon, 29 Feb 2016 08:08:27 GMT
GitHub user makefu opened a pull request:

    https://github.com/apache/hadoop/pull/81

    Shell.java: fix absolute path `/bin/ls`

    This commit uses `ls` from PATH instead of relying on `ls` being stored in `/bin/`. The
only file according to the POSIX standard which must be stored in `/bin/` is `sh`.
    This fixes issues plaguing distributions like NixOS which dynamically stitch together
a PATH.
    
    This fix is loosly related to https://issues.apache.org/jira/browse/HADOOP-11935 and more
specifically related to https://mail-archives.apache.org/mod_mbox/hadoop-user/201512.mbox/%3CCAH2nEUgsSeoJTJkD4T8z=D18ECnRgQ3Qvz861gU5+NPSsNgT=A@mail.gmail.com%3E

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/makefu/hadoop patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/hadoop/pull/81.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #81
    
----
commit 4e8f93d8eecce551b1eebd531c71e3c7144c9210
Author: Felix Richter <github@syntax-fehler.de>
Date:   2016-02-29T08:08:06Z

    Shell.java: fix absolute path `/bin/ls`
    
    This commit uses `ls` from PATH instead of relying on `ls` being stored in `/bin/`. The
only file according to the POSIX standard which must be stored in `/bin/` is `sh`.
    This fixes issues plaguing distributions like NixOS which dynamically stitch together
a PATH.
    
    This fix is loosly related to https://issues.apache.org/jira/browse/HADOOP-11935 and more
specifically related to https://mail-archives.apache.org/mod_mbox/hadoop-user/201512.mbox/%3CCAH2nEUgsSeoJTJkD4T8z=D18ECnRgQ3Qvz861gU5+NPSsNgT=A@mail.gmail.com%3E

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message