Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-dev@hadoop.apache.org
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\))
Subject: Re: Need for force-push on feature branches
From: Allen Wittenauer <aw@altiscale.com>
In-Reply-To: 
 <CADbBEnuFO0xh06EJLfPqHeH4+TCYCyz3mxKfCM8tsJjXrah88w@mail.gmail.com>
Date: Thu, 12 Nov 2015 10:08:43 -0800
Content-Transfer-Encoding: quoted-printable
Message-Id: <4C8580EE-5263-4862-8C49-EEA718AD2885@altiscale.com>
References: 
 <CALwhT94_OW-Dg1F5wiBZBHTYgtyrEFLnzy+Yecyo6XL8BP8suQ@mail.gmail.com>
 <24B40D0D-1ADF-4AD7-910D-586D4F571BED@hortonworks.com>
 <EB84BE83-FAB6-4A95-82D4-3A87A6F4AF43@hortonworks.com>
 <CADbBEnsBDpZtxpRitQ=7UY04K3YNfh=uF91Z+d-dF8jK35VkLA@mail.gmail.com>
 <3D9E3DF7-9017-45F1-AFDB-C82A6073E6FD@hortonworks.com>
 <CADbBEnsNpn84Q5BX3V6RSzg54KxA9NOihu57H9Q+RRfRu3=Uow@mail.gmail.com>
 <DBAC27A5-D685-4FD7-A837-AD928ECC4623@hortonworks.com>
 <CADbBEnuFO0xh06EJLfPqHeH4+TCYCyz3mxKfCM8tsJjXrah88w@mail.gmail.com>
To: common-dev@hadoop.apache.org


Implementing project-specific patch identification rules are definitely =
=E2=80=98not trivial=E2=80=99.

FWIW, the documented ruleset Yetus supports is here:=20

	=
https://yetus.apache.org/documentation/latest/precommit-patchnames/

(Altho, in reality, the code does support more than this but they are =
sort of weird looking, etc.)

> On Nov 12, 2015, at 10:04 AM, Sangjin Lee <sjlee0@gmail.com> wrote:
>=20
> I suppose that would be fine too. Yetus just needs to add "feature/" =
to the
> git branch name when it fails to find it as is. So it would require a
> little work on yetus, but I guess should be pretty trivial?
>=20
> On Thu, Nov 12, 2015 at 9:59 AM, Steve Loughran =
<stevel@hortonworks.com>
> wrote:
>=20
>>=20
>>> On 12 Nov 2015, at 17:49, Sangjin Lee <sjlee0@gmail.com> wrote:
>>>=20
>>> Yes, I completely understand about the git branch naming practice =
(in
>> fact
>>> that's what I normally do). I was commenting on our hadoop patch =
naming
>>> convention. We are supposed to use patch names as
>>> "<jira-id>-<branch-name-if-not-trunk>.<sequence>.patch".
>>>=20
>>> If we used "feature/HADOOP-12345" as the git branch name and the =
subtask
>>> JIRA was HADOOP-67890 for example, the patch file name would be
>>> "HADOOP-67890-feature/HADOOP-12345.001.patch", which would not be =
doable,
>>> no? For that to work, we would need to have some kind of escaping
>>> convention which jenkins and users follow.
>>>=20
>>=20
>> aah, now I follow. wouldn't HADOOP-12345.001.patch be enough?
>>=20