hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sangjin Lee <sjl...@gmail.com>
Subject Re: Need for force-push on feature branches
Date Thu, 12 Nov 2015 17:49:42 GMT
Yes, I completely understand about the git branch naming practice (in fact
that's what I normally do). I was commenting on our hadoop patch naming
convention. We are supposed to use patch names as
"<jira-id>-<branch-name-if-not-trunk>.<sequence>.patch".

If we used "feature/HADOOP-12345" as the git branch name and the subtask
JIRA was HADOOP-67890 for example, the patch file name would be
"HADOOP-67890-feature/HADOOP-12345.001.patch", which would not be doable,
no? For that to work, we would need to have some kind of escaping
convention which jenkins and users follow.


On Thu, Nov 12, 2015 at 1:23 AM, Steve Loughran <stevel@hortonworks.com>
wrote:

>
> > On 11 Nov 2015, at 22:47, Sangjin Lee <sjlee@apache.org> wrote:
> >
> > If we do use "feature/..." as the branch naming convention, it does pose
> an
> > issue with the patch naming due to the separator character ('/'). How
> about
> > "feature-..."?
>
> In most spark UIs, they get treated as subdirectories and easier to
> manager. Try it on something like sourcetree.
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message