Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-dev@hadoop.apache.org
Date: Sat, 10 Oct 2015 10:25:06 +0000 (UTC)
From: "Haohui Mai (JIRA)" <jira@apache.org>
To: common-dev@hadoop.apache.org
Message-ID: <JIRA.12903596.1444354216000.6496.1444472706391@Atlassian.JIRA>
In-Reply-To: <JIRA.12903596.1444354216000@Atlassian.JIRA>
References: <JIRA.12903596.1444354216000@Atlassian.JIRA>
 <JIRA.12903596.1444354216962@arcas>
Subject: [jira] [Reopened] (HADOOP-12469) distcp shout not ignore the
 ignoreFailures option
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HADOOP-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Haohui Mai reopened HADOOP-12469:
---------------------------------

Reopening the jira.

Sorry for the noise -- I realized that I haven't posted my +1 on the patch before committing. Taking a closer look the patch, it does not seem to really address the problem. I'm going to revert it now.

> distcp shout not ignore the ignoreFailures option
> -------------------------------------------------
>
>                 Key: HADOOP-12469
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12469
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: tools/distcp
>    Affects Versions: 2.7.1
>            Reporter: Gera Shegalov
>            Assignee: Mingliang Liu
>            Priority: Critical
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-12469.000.patch
>
>
> {{RetriableFileCopyCommand.CopyReadException}} is double-wrapped via
> # via {{RetriableCommand::execute}}
> # via {{CopyMapper#copyFileWithRetry}}
> before {{CopyMapper::handleFailure}} tests 
> {code}
> if (ignoreFailures && exception.getCause() instanceof
>             RetriableFileCopyCommand.CopyReadException
> {code}
> which is always false.
> Orthogonally, ignoring failures should be mutually exclusive with the atomic option otherwise an incomplete dir is eligible for commit defeating the purpose.
>  


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)