Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-dev@hadoop.apache.org
MIME-Version: 1.0
In-Reply-To: <88B588D6-8301-49BE-83A8-54E92A729988@altiscale.com>
References: <F827089A-B8A1-4662-86F8-AAB92FBB843A@altiscale.com>
 <C8AF58A8-4790-4FF6-83B0-BE6E1B1930BB@altiscale.com>
 <396078FB-C091-456B-9D5F-FC271F46914C@hortonworks.com>
 <56022842-FB6D-4A8A-9236-FB950A1DD9C4@altiscale.com>
 <CAGB5D2YHPwS1uZ8iODONZd2CrGqF_9f5F2WuGp-8ozMPe-iMag@mail.gmail.com>
 <88B588D6-8301-49BE-83A8-54E92A729988@altiscale.com>
From: Andrew Wang <andrew.wang@cloudera.com>
Date: Mon, 19 Oct 2015 11:09:05 -0700
Message-ID: 
 <CAGB5D2arZ_Pb_=nAVUhJ+3uCD=bHD2UDp6yCKX1H48XN1r1LBg@mail.gmail.com>
Subject: Re: Status: hadoop-common precommit
To: "common-dev@hadoop.apache.org" <common-dev@hadoop.apache.org>
Content-Type: multipart/alternative; boundary=001a114361649602880522790b6a

--001a114361649602880522790b6a
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Could we make it so we run RAT after building docs but before running
tests? I think that's what's causing these issues, it looks like temp
output from running tests. This would be a nice intermediate step toward
that plug-in you mentioned, since test output is certainly not part of the
release tarball.

These tests should still be fixed up to use target/ instead of
build/test/data though. Steve, I'm happy to review if you're chasing these
down, or we could trade roles.

On Mon, Oct 19, 2015 at 9:43 AM, Allen Wittenauer <aw@altiscale.com> wrote:

>
> On Oct 19, 2015, at 9:21 AM, Andrew Wang <andrew.wang@cloudera.com> wrote=
:
>
> > Question, are these errors from running apache-rat:check after running
> > tests? build/test/data looks like a carry-over from the ant days, where
> it
> > was used instead of target/blah/blah. Point being, I thought we only
> needed
> > to run RAT on a clean source directory.
>
> It was moved to after to account for files generated as part of the build
> that are then packaged up, such as documentation.  Those also have to be
> properly licensed.  In the future, I could easily see a Yetus plug-in tha=
t
> rips apart a release artifact and verifies it, but we=E2=80=99re not quit=
e that
> advanced yet.

--001a114361649602880522790b6a--