hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Pivovarov <apivova...@gmail.com>
Subject Re: Github integration for Hadoop
Date Fri, 30 Oct 2015 07:38:07 GMT
Andrew, look at Spark github. They use PRs and I do not see extra merge
commits. Committer can do fast-farward merge using git command line.
PRs are used to leave inline feedbacks for the fix
On Oct 29, 2015 1:34 PM, "Andrew Wang" <andrew.wang@cloudera.com> wrote:

> Has anything changed regarding the github integration since the last time
> we discussed this? That blog post is from 2014, and we discussed
> alternative review systems earlier in 2015.
>
> Colin specifically was concerned about forking the discussion between JIRA
> and other places:
>
> http://search-hadoop.com/m/uOzYtkYxo4qazi&subj=Re+Patch+review+process
> http://search-hadoop.com/m/uOzYtSz7z624qazi&subj=Re+Patch+review+process
>
> There are also questions about PRs leading to messy commit history with the
> extra merge commits. Spark IIRC has something to linearize it again, which
> seems important if we actually want to do this.
>
> Could someone outline the upsides of using github? I don't find the review
> UI particularly great compared to Gerrit or even RB, and there's the merge
> commit issue. For instance, do we think using Github would lead to more
> contributions? Improved developer workflows? Have we re-examined
> alternatives like Gerrit or RB as well?
>
> On Thu, Oct 29, 2015 at 12:25 PM, Arpit Agarwal <aagarwal@hortonworks.com>
> wrote:
>
> > +1, thanks for proposing it.
> >
> >
> >
> >
> >
> > On 10/29/15, 10:47 AM, "Owen O'Malley" <omalley@apache.org> wrote:
> >
> > >All,
> > >   For code & patch review, many of the newer projects are using the
> > Github
> > >pull request integration. You can read about it here:
> > >
> > >
> >
> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
> > >
> > >It basically lets you:
> > >* have mirroring between comments on pull requests and jira
> > >* lets you close pull requests
> > >* have mirroring between pull request comments and the Apache mail lists
> > >
> > >Thoughts?
> > >.. Owen
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message