hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Wang <andrew.w...@cloudera.com>
Subject Re: Status: hadoop-common precommit
Date Mon, 19 Oct 2015 18:09:05 GMT
Could we make it so we run RAT after building docs but before running
tests? I think that's what's causing these issues, it looks like temp
output from running tests. This would be a nice intermediate step toward
that plug-in you mentioned, since test output is certainly not part of the
release tarball.

These tests should still be fixed up to use target/ instead of
build/test/data though. Steve, I'm happy to review if you're chasing these
down, or we could trade roles.

On Mon, Oct 19, 2015 at 9:43 AM, Allen Wittenauer <aw@altiscale.com> wrote:

>
> On Oct 19, 2015, at 9:21 AM, Andrew Wang <andrew.wang@cloudera.com> wrote:
>
> > Question, are these errors from running apache-rat:check after running
> > tests? build/test/data looks like a carry-over from the ant days, where
> it
> > was used instead of target/blah/blah. Point being, I thought we only
> needed
> > to run RAT on a clean source directory.
>
> It was moved to after to account for files generated as part of the build
> that are then packaged up, such as documentation.  Those also have to be
> properly licensed.  In the future, I could easily see a Yetus plug-in that
> rips apart a release artifact and verifies it, but we’re not quite that
> advanced yet.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message