hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Wang <andrew.w...@cloudera.com>
Subject Re: Github integration for Hadoop
Date Sat, 31 Oct 2015 00:08:58 GMT
Thanks Owen. I'll volunteer myself and Colin to review the docs when you
put them together.

Regarding open q's, from my earlier email:

=====

Great, glad to hear it. That wasn't mentioned in the email thread or on the
INFRA ticket, and the INFRA ticket mentions these integrations:

Commit Comment, Create, Issue Comment, Issues, Pull Request, Pull Request
Comment, and push, Push

Are these the right set of permissions to disable integrating PRs? Namely,
the "push" permissions look unnecessary. We should also disable GH issues
since we don't want users filing issues there.

====

Another item is testing precommit. One thing we should verify that it works
with different branches (e.g. branch-2 and trunk). I'm also interested in
the failure mode when a PR has multiple commits, since Allen called it out.

Best,
Andrew

On Fri, Oct 30, 2015 at 4:55 PM, Owen O'Malley <omalley@apache.org> wrote:

> On Fri, Oct 30, 2015 at 2:37 PM, Andrew Wang <andrew.wang@cloudera.com>
> wrote:
>
> >
> > Strongly agree that we need documentation for all this.
>
>
> Agreed.
>
>
> > Some of my open questions are also still pending.
> >
>
> Which open questions?
>
> Owen, are you chasing all of this down? Do we need some JIRAs to track?
> >
>
> Yeah, I'll take a first pass at it. I think jiras are overkill.
>
> .. Owen
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message