hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Wang <andrew.w...@cloudera.com>
Subject Re: Github integration for Hadoop
Date Fri, 30 Oct 2015 00:14:42 GMT
On Thu, Oct 29, 2015 at 4:58 PM, Arpit Agarwal <aagarwal@hortonworks.com>
wrote:

> On 10/29/15, 3:48 PM, "Andrew Wang" <andrew.wang@cloudera.com> wrote:
>
>
> > If we pushed for it, I think it could happen.
>
> Gerrit support is a complete unknown. The community response to date
> supports Github integration. Github will appeal to new contributors as
> their Github profiles will reflect their work. I'd be interested in hearing
> more contributor opinions.
>
> Owen said above that he was proposing using github as a review tool, not
for code integration. So contributors wouldn't have anything showing up on
their github profiles, since we aren't directly taking PRs.

However, if we were to use GH for integration, it would be with the
auto-squash to avoid the merge commit. Would this preserve the correct
attribution?

>
> > If that's the case, we should also look at review alternatives
> > like RB and Crucible.
>
> Okay by me if the community consensus supports one of them. The fact that
> they exist but no one uses them is not a ringing endorsement.
>
> HBase uses reviewboard, as do I'm sure other Apache projects.
reviews.apache.org existed before we had github integration. I've used RB a
fair bit, and don't mind it.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message