hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin P. McCabe" <cmcc...@apache.org>
Subject Re: Doubts about review and validation process
Date Wed, 19 Aug 2015 19:14:14 GMT
Hi Augusto,

Sorry that we haven't gotten back to you in a while.  This isn't my
area of expertise, but hopefully someone will step forward to look at
the MR stuff.

It seems like maybe you need a design document for the preemption
stuff.  Each JIRA gives a small piece of the puzzle, but it's hard to
fit them together without some background.

best,
Colin

On Mon, Aug 10, 2015 at 6:32 AM, Augusto Souza <augustorsouza@gmail.com> wrote:
> Hello,
>
> I have been working on continuing Carlo Curino and Chris Douglas
> contribution on https://issues.apache.org/jira/browse/MAPREDUCE-5269. After
> some iterations, we decided to split this patch into smaller ones to make
> easier for reviewers to check it and to pass Jenkins validations.
>
> The first two sub-products of this splitting are
> https://issues.apache.org/jira/browse/MAPREDUCE-6434and
> https://issues.apache.org/jira/browse/MAPREDUCE-6444 (and I am planning
> another one to finish the work that depends on these two).
>
> I have some doubts related to the review process for each of these
> improvements:
>
> 1) *MAPREDUCE-6434*: How can I have the patch accepted now that it is
> approved by Jenkins and passed every test?
>
> 2) *MAPREDUCE-6444*: How can I solve checkstyle issues related to the
> number of parameters in some methods I created (more than seven)? I noticed
> there are other methods in hadoop source code with more than 7 parameters,
> the most part of my changes were in old methods that already had more than
> 7 parameters and I added other parameters to it and got caught by
> checkstyle validation.
>
> Thanks in advance!
>
> Best regards,
> Augusto Souza

Mime
View raw message