hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alan Burlison <Alan.Burli...@oracle.com>
Subject Re: Patch advice rerquired: trailing whitespace cleanup
Date Fri, 19 Jun 2015 16:42:33 GMT
On 19/06/2015 17:19, Chris Nauroth wrote:

> If it flags a warning on a line of code that your patch touches, then go
> ahead and trim the whitespace.  If you find that it flags a warning on a
> line of code in the surrounding diff context, but not something that
> you're actually changing, then don't bother.  I agree that doing a mass
> clean-up would make a patch noisy and more difficult to review.
> There are some known issues with false positives on the whitespace check
> right now.  Fixes are in progress.

Will do as you suggest, thanks.

Alan Burlison

View raw message