Return-Path: X-Original-To: apmail-hadoop-common-dev-archive@www.apache.org Delivered-To: apmail-hadoop-common-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 65C8D10C97 for ; Tue, 5 May 2015 23:58:11 +0000 (UTC) Received: (qmail 26142 invoked by uid 500); 5 May 2015 23:58:09 -0000 Delivered-To: apmail-hadoop-common-dev-archive@hadoop.apache.org Received: (qmail 26061 invoked by uid 500); 5 May 2015 23:58:09 -0000 Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-dev@hadoop.apache.org Delivered-To: mailing list common-dev@hadoop.apache.org Received: (qmail 26046 invoked by uid 99); 5 May 2015 23:58:09 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 May 2015 23:58:09 +0000 X-ASF-Spam-Status: No, hits=2.2 required=5.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: message received from 54.191.145.13 which is an MX secondary for common-dev@hadoop.apache.org) Received: from [54.191.145.13] (HELO mx1-us-west.apache.org) (54.191.145.13) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 May 2015 23:58:05 +0000 Received: from mail-ig0-f180.google.com (mail-ig0-f180.google.com [209.85.213.180]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTPS id E4833207A3 for ; Tue, 5 May 2015 23:57:44 +0000 (UTC) Received: by igbhj9 with SMTP id hj9so2813303igb.1 for ; Tue, 05 May 2015 16:57:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type; bh=V9HOV5DYcpi4Jt51HaIZx8baE1osvRmb0PChmvKm6fY=; b=bEZn+D6EjcLBtdcLNc8+k1oeC6LLmDCWT95LjNSVIQCsPrUb6Dy5ylAykTrVzQJ7Eu 8p/HsnxI434tOhKJo6qKm3GaDGwQCNWbt8tTB/jDrbTKYU/bhzpGSFhlPzo5jKpR+W25 LedTauWkYrqd3VcJU82tkmFAkfmYn47q3u78GnaGavFWDvQ77yXBD5bgRIrONiQUD2Co 4fPJ+FHyemvNmZDadm5eV6KV/JmstZA6Bk+BJV/0vfJBlEXpf/66Fm1k6b9FQN6OjpRk dfGo3GJMWQR7Ni9X9ywuLuxKpnf1woQzl90bQKX+PTMmN7G3g3RNl5lNrdKEsCqxJM1E zxnQ== X-Gm-Message-State: ALoCoQnubo2FCJTAPtfZ2qDmSpUSVgtBp7NhWVxHNUXmi7X187Ik+zkoMafZ6LSy/5dC1OqLiwfs X-Received: by 10.50.142.2 with SMTP id rs2mr5008317igb.1.1430870264308; Tue, 05 May 2015 16:57:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.3.219 with HTTP; Tue, 5 May 2015 16:57:23 -0700 (PDT) In-Reply-To: References: From: Andrew Wang Date: Tue, 5 May 2015 16:57:23 -0700 Message-ID: Subject: Re: Checkstyle 80 char limit To: "common-dev@hadoop.apache.org" Content-Type: multipart/alternative; boundary=001a1133d3d2d317ea05155e7179 X-Virus-Checked: Checked by ClamAV on apache.org --001a1133d3d2d317ea05155e7179 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I typically split my IDE into two side-by-side panes, the 80 char limit works pretty well once you factor in the side panes too. I've worked on a project with a 100 char limit, and that's about the point where even my 30" monitor needs side scrolling. I think Colin pretty much nailed it with his reasons. We need some limit, very wide lines hurt readability, if you run into issues consider refactoring your code. I've had annoyances with long variable or method names, but nothing so egregious that makes me want to up it from 80 (and I have reviewed some code in distcp too). I use the autoformatter in my IDE and let the magic happen. Best, Andrew On Tue, May 5, 2015 at 3:46 PM, Rich Haase wrote: > Jay, > > Does bigtop use a line length limit at all? I was mostly hoping that we > could update to using a limit that was more appropriate (IMO) to modern > IDEs, like 100-120 chars perhaps? > > > On May 5, 2015, at 4:38 PM, jay vyas jayunit100.apache@gmail.com>> wrote: > > im glad you've started this thread. > > 1) i like the idea of dropping the 80 char limit ! > > 2) and indeed, we've now adopted it in ASF BigTop, where we try to take > queues from hadoop when possible. > > On Tue, May 5, 2015 at 3:53 PM, Rich Haase rhaase@pandora.com>> wrote: > > Arun, > > I use my IDE split vertically all the time on projects without strict lin= e > limits and I have never had a problem seeing the code from multiple class= es > in such a setup. > > I can certainly setup my IDE to only do 80 characters a line, although I > think it hurts readability in many cases where long names force method > calls to wrap across many lines. The reason I initially asked about the > line length limit being so low is that I am having to reformat a quite a > bit of the distcp code in order to submit a patch. It=E2=80=99s clear to= me that > distcp did not follow the code standards being checked by checkstyle. > While I don=E2=80=99t mind refactoring code to meet a standard I think th= at > standard should reflect the state of development environments used this > decade. > > Rich > > On May 5, 2015, at 1:36 PM, Arun Suresh asuresh@cloudera.com> asuresh@cloudera.com>> wrote: > > My 2 cents : > I actually like the lower char limit. Since most of the time, I end up > having to switch between classes, I end up splitting my screen vertically > and having multiple files open. for some reason, I find splitting > vertically is better for readability than horizontally. > In anycase, my IDE generally helps me format to 80 chars so, it has never > been a pain point for me. > > On Tue, May 5, 2015 at 12:30 PM, Niels Basjes Niels@basjes.nl> Niels@basjes.nl>> wrote: > > I respect immensely the contributions Doug has made to many Apache > projects, > > Hear hear! I fully agree with that one. > > On Tue, May 5, 2015 at 8:30 PM, Rich Haase rhaase@pandora.com> rhaase@pandora.com>> wrote: > > I respect immensely the contributions Doug has made to many Apache > projects, but I don=E2=80=99t think that should be a reason to force ever= yone to > write code as if our screen sizes can=E2=80=99t support more than 80 char= acters. > > On May 5, 2015, at 12:21 PM, Niels Basjes Niels@basjes.nl> Niels@basjes.nl> Niels@basjes.nl>> wrote: > > Perhaps we should tell him these screens can also be turned landscape ? > ;) > > But seriously: > 1) Does Doug still actively work on code? From my perspective; Only very > infrequently. > 2) In the 200+ people IT department where I work I know only 1 colleague > who uses his screen in portrait mode and he doesn't do code. > > So, for who do we really stick to the 80 chars limit? > > Niels > > On Tue, May 5, 2015 at 8:11 PM, Allen Wittenauer aw@altiscale.com> aw@altiscale.com> > aw@altiscale.com>> > wrote: > > > On May 5, 2015, at 11:05 AM, Rich Haase rhaase@pandora.com> rhaase@pandora.com> rhaase@pandora.com>= > > wrote: > > Can someone explain to me why on earth we care about limiting line > length to 80 characters? Are there hadoop developers out there working > from teletype terminals? Can we perhaps update this limit to something > sane, like 120 chars? > > > > > > > > > http://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201407.mbox/%3= CCALEq1Z8QvHof1A3zO0W5WGfbNjCOpfNo=3D=3DJktQ8JiU6eFM_1RQ@mail.gmail.com%3E > > > > > > -- > Best regards / Met vriendelijke groeten, > > Niels Basjes > > Rich Haase| Sr. Software Engineer | Pandora > m (303) 887-1146 | rhaase@pandora.com awilson2@pandora.com> > > > > > > > -- > Best regards / Met vriendelijke groeten, > > Niels Basjes > > > Rich Haase| Sr. Software Engineer | Pandora > m (303) 887-1146 | rhaase@pandora.com rhaase@pandora.com> > > > > > > > > -- > jay vyas > > Rich Haase| Sr. Software Engineer | Pandora > m (303) 887-1146 | rhaase@pandora.com > > > > > --001a1133d3d2d317ea05155e7179--