Return-Path: X-Original-To: apmail-hadoop-common-dev-archive@www.apache.org Delivered-To: apmail-hadoop-common-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5BC261020A for ; Tue, 19 May 2015 16:51:54 +0000 (UTC) Received: (qmail 89424 invoked by uid 500); 19 May 2015 16:51:52 -0000 Delivered-To: apmail-hadoop-common-dev-archive@hadoop.apache.org Received: (qmail 89343 invoked by uid 500); 19 May 2015 16:51:52 -0000 Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-dev@hadoop.apache.org Delivered-To: mailing list common-dev@hadoop.apache.org Received: (qmail 89332 invoked by uid 99); 19 May 2015 16:51:52 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 May 2015 16:51:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 15AA9182929 for ; Tue, 19 May 2015 16:51:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.031 X-Spam-Level: X-Spam-Status: No, score=-0.031 tagged_above=-999 required=6.31 tests=[RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 7WbJHHKU99O8 for ; Tue, 19 May 2015 16:51:46 +0000 (UTC) Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id 97B0124965 for ; Tue, 19 May 2015 16:51:45 +0000 (UTC) Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t4JGocA7007164 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 19 May 2015 16:50:38 GMT Received: from [141.144.10.154] (alanbur-nsvpn-pc1.vpn.oracle.com [141.144.10.154]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t4JGoaC1026831; Tue, 19 May 2015 16:50:37 GMT Message-ID: <555B69DC.7080902@oracle.com> Date: Tue, 19 May 2015 17:50:36 +0100 From: Alan Burlison Organization: Oracle User-Agent: Mozilla/5.0 (X11; SunOS i86pc; rv:17.0) Gecko/20150410 Thunderbird/17.0.11 MIME-Version: 1.0 To: common-dev@hadoop.apache.org CC: "Colin P. McCabe" , Mai Haohui Subject: Re: JNIFlags.cmake versus FindJNI.cmake References: <55568DAC.1040303@oracle.com> <5556F368.6040103@oracle.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] On 19/05/2015 17:34, Colin P. McCabe wrote: > Thanks for looking at this code, Alan. I appreciate your desire to > clean things up. However, as I commented on HADOOP-11987, > JNIFlags.cmake contains many fixes not in the standard FindJNI.cmake. > I very much doubt that we will be able to remove it without causing > significant regressions. I guess we can continue the discussion on > the JIRA. Sure, I'm typing up some comments right now :-) Thanks, -- Alan Burlison --