Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-dev@hadoop.apache.org
Received-SPF: pass (nike.apache.org: message received from 54.76.25.247 which
 is an MX secondary for common-dev@hadoop.apache.org)
MIME-Version: 1.0
Sender: niels@basj.es
In-Reply-To: <331639B3-00AD-4709-8BBA-37746B52BDBC@altiscale.com>
References: <ACEFED78-5640-4439-8F1C-26027214F7D7@altiscale.com>
	<4146734C-9CB4-44B9-9094-3B943040A4AE@hortonworks.com>
	<37876915-3DD3-404F-B398-5035ABCE08AC@altiscale.com>
	<331639B3-00AD-4709-8BBA-37746B52BDBC@altiscale.com>
Date: Thu, 23 Apr 2015 00:18:41 +0200
Message-ID: 
 <CADoiZqoEN8Cukjiqt8ozO7OCUdbNetoaxJ4frk22VX2X+H=pYA@mail.gmail.com>
Subject: Re: IMPORTANT: testing patches for branches
From: Niels Basjes <Niels@basjes.nl>
To: common-dev@hadoop.apache.org
Cc: "hdfs-dev@hadoop.apache.org" <hdfs-dev@hadoop.apache.org>,
 mapreduce-dev@hadoop.apache.org,
	"yarn-dev@hadoop.apache.org" <yarn-dev@hadoop.apache.org>
Content-Type: multipart/alternative; boundary=001a11c25d36ac06d10514578bea

--001a11c25d36ac06d10514578bea
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Perhaps a script is due that creates the patch file with -exactly- the
right name.
Something like what HBase has as dev-support/make_patch.sh perhaps?

On Wed, Apr 22, 2015 at 10:30 PM, Allen Wittenauer <aw@altiscale.com> wrote=
:

>
> Oh, this is also in the release notes, but one can use a git reference #
> as well. :) (with kudos to OOM for the idea.)
>
> On Apr 22, 2015, at 8:57 PM, Allen Wittenauer <aw@altiscale.com> wrote:
>
> >
> > More than likely. It probably needs more testing (esp under Jenkins).
> >
> > It should be noted that the code in test-patch.sh has lots of problems
> with branch-0, minor, and micro releases.  But for major releases, it see=
ms
> to work well for me. :)
> >
> > On Apr 22, 2015, at 8:45 PM, Vinod Kumar Vavilapalli <
> vinodkv@hortonworks.com> wrote:
> >
> >> Does this mean HADOOP-7435 is no longer needed / closeable as dup?
> >>
> >> Thanks
> >> +Vinod
> >>
> >> On Apr 22, 2015, at 12:34 PM, Allen Wittenauer <aw@altiscale.com>
> wrote:
> >>
> >>>
> >>> Hey gang,
> >>>
> >>>     Just so everyone is aware, if you are working on a patch for
> either a feature branch or a major branch, if you name the patch with the
> branch name following the spec in HowToContribute (and a few other ways=
=E2=80=A6
> test-patch tries to figure it out!), test-patch.sh *should* be switching
> the repo over to that branch for testing.
> >>>
> >>>     For example,  naming a patch foo-branch-2.01.patch should get
> tested on branch-2.  Naming a patch foo-HDFS-7285.00.patch should get
> tested on the HDFS-7285 branch.
> >>>
> >>>     This hopefully means that there should really be no more =E2=80=
=98blind=E2=80=99
> +1=E2=80=99s to patches that go to branches.  The =E2=80=9Cwe only test a=
gainst trunk=E2=80=9D
> argument is no longer valid. :)
> >>>
> >>>
> >>
> >
>
>


--=20
Best regards / Met vriendelijke groeten,

Niels Basjes

--001a11c25d36ac06d10514578bea--