hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Nauroth <cnaur...@hortonworks.com>
Subject Re: Native style guide
Date Tue, 03 Feb 2015 23:19:53 GMT
Hi Steve,

I don't believe we have an official statement of the native code style, so
that's something that would be beneficial.

To address your immediate question, yes, it is acceptable to use goto in
error checking logic to jump to a labeled cleanup routine.  This is an
established pattern throughout the native codebase.  One example file is
NativeIO.c.

Chris Nauroth
Hortonworks
http://hortonworks.com/






On 2/3/15, 1:39 PM, "Steve Loughran" <stevel@hortonworks.com> wrote:

>
>Do we have a native code style guide?
>
>Specifically, it is OK to use goto as a way of bailing out of things and
>into some memory release logic as part of some JNI exception generation
>routine?
>
>Don't worry, I'm asking on behalf of someone else
>
>
>-Steve
>
>ps: what I have been intermittently doing is writing a proper style guide
>for the Java side of things.
>
>https://github.com/steveloughran/formality/blob/master/styleguide/stylegui
>de.md


Mime
View raw message