hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Douglas <cdoug...@apache.org>
Subject Re: Patch review process
Date Wed, 11 Feb 2015 22:12:20 GMT
On Wed, Feb 11, 2015 at 2:04 PM, Steve Loughran <stevel@hortonworks.com> wrote:
> At the same time, if only 1 person is looking at a part of the codebase & submitting
patches, they have inherently recused themselves from reviewing on their own patches. Ideally
you want >1 committer tracking a topic. That's someone with competence in the area too,
obviously; a barrier to participation in the corner areas.

That was what I was trying to convey. With RTC, if there's only one
person working in an area, then they can't make progress.

> started with https://issues.apache.org/jira/browse/INFRA-9152

Great; thanks Steve.

> though I'm not sure the diff between fisheye and cruicible here; they seem blurred

>From [1]:
FishEye allows you to extract information from your source code
repository and display it in sophisticated reports.
Crucible allows you to request, perform and manage code reviews.

[1] https://confluence.atlassian.com/display/CRUCIBLE/Crucible+and+FishEye


> On Tue, Feb 10, 2015 at 1:19 PM, Chris Nauroth <cnauroth@hortonworks.com> wrote:
>> I don¹t anticipate a patch manager introducing a new bottleneck.
>> As originally described by Chris D, the role of the patch manager is not
>> to review and commit all patches in an assigned area. Instead, the
>> responsibility is queue management: following up on dormant jiras to make
>> sure progress is made. This might involve the patch manager doing the
>> review and commit, but it also might mean contacting someone else for
>> review, closing it if it¹s a duplicate, or making a won¹t-fix decision.
>> It¹s the kind of activity that Allen and Steve have done a lot lately.
>> I see the patch manager role as addressing the fact that the community
>> itself has grown large and complex. As others have mentioned, it¹s not
>> always clear to a new contributor who to ask for a code review. A patch
>> manager would be familiar enough with the community to help steer their
>> patches in the right direction.
>> I suppose we don¹t need to formalize this too much. If anyone feels
>> capable of doing this kind of queue management in a certain area of
>> expertise, please dive in. Congratulations, you are now a patch manager!
>> I¹m sure everyone would appreciate it.

View raw message