hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colin McCabe <cmcc...@alumni.cmu.edu>
Subject Re: a friendly suggestion for developers when uploading patches
Date Mon, 01 Dec 2014 18:22:46 GMT
On Wed, Nov 26, 2014 at 2:58 PM, Karthik Kambatla <kasha@cloudera.com>
wrote:

> Yongjun, thanks for starting this thread. I personally like Steve's
> suggestions, but think two digits should be enough.
>
> I propose we limit the restrictions to versioning the patches with version
> numbers and .patch extension. People have their own preferences for the
> rest of the name (e.g. MAPREDUCE, MapReduce, MR, mr, mapred) and I don't
> see a gain in forcing everyone to use one.
>
> Putting the suggestions (tight and loose) on the wiki would help new
> contributors as well.
>
>
+1

best,
Colin


> On Wed, Nov 26, 2014 at 2:43 PM, Eric Payne <erichadoop-1@yahoo.com.invalid
> >
> wrote:
>
> > +1.The "different color for newest patch" doesn't work very well if you
> > are color blind, so I do appreciate a revision number in the name.
> >
> >       From: Yongjun Zhang <yzhang@cloudera.com>
> >  To: common-dev@hadoop.apache.org
> >  Sent: Tuesday, November 25, 2014 11:37 PM
> >  Subject: Re: a friendly suggestion for developers when uploading patches
> >
> > Thanks Harsh for the info and Andrew for sharing the script. It looks
> that
> > the script is intelligent enough to pick the latest attachment even if
> all
> > attachments have the same name.
> >
> > Yet, I hope we use the following as the guideline for patch names:
> >
> > <*projectName*>-<*jiraNum*>-<*revNum*>.patch
> >
> >
> > So we can easily identify individual patch revs.
> >
> > Thanks.
> >
> > --Yongjun
> >
> > On Tue, Nov 25, 2014 at 5:54 PM, Andrew Wang <andrew.wang@cloudera.com>
> > wrote:
> >
> > > This might be a good time to mention my fetch-patch script, I use it to
> > > easily download the latest attachment on a jira:
> > >
> > > https://github.com/umbrant/dotfiles/blob/master/bin/fetch-patch
> > >
> > > On Tue, Nov 25, 2014 at 5:44 PM, Harsh J <harsh@cloudera.com> wrote:
> > >
> > > > For the same filename, you can observe also that the JIRA colors the
> > > > latest one to be different than the older ones automatically - this
> is
> > > > what I rely on.
> > > >
> > > > On Sat, Nov 22, 2014 at 12:36 AM, Yongjun Zhang <yzhang@cloudera.com
> >
> > > > wrote:
> > > > > Hi,
> > > > >
> > > > > When I look at patches uploaded to jiras, from time to time I
> notice
> > > that
> > > > > different revisions of the patch is uploaded with the same patch
> file
> > > > name,
> > > > > some time for quite a few times. It's confusing which is which.
> > > > >
> > > > > I'd suggest that as a guideline, we do the following when
> uploading a
> > > > patch:
> > > > >
> > > > >    - include a revision number in the patch file name.A
> > > > >    - include a comment, stating that a new patch is uploaded,
> > including
> > > > the
> > > > >    revision number of the patch in the comment.
> > > > >
> > > > > This way, it's easier to refer to a specific version of a patch,
> and
> > to
> > > > > know which patch a comment is made about.
> > > > >
> > > > > Hope that makes sense to you.
> > > > >
> > > > > Thanks.
> > > > >
> > > > > --Yongjun
> > > >
> > > >
> > > >
> > > > --
> > > > Harsh J
> > > >
> > >
> >
> >
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message