Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-dev@hadoop.apache.org
Date: Thu, 20 Nov 2014 06:30:34 +0000 (UTC)
From: "Dian Fu (JIRA)" <jira@apache.org>
To: common-dev@hadoop.apache.org
Message-ID: <JIRA.12756635.1416464982000.542114.1416465034486@Atlassian.JIRA>
In-Reply-To: <JIRA.12756635.1416464982000@Atlassian.JIRA>
References: <JIRA.12756635.1416464982000@Atlassian.JIRA>
 <JIRA.12756635.1416464982799@arcas>
Subject: [jira] [Created] (HADOOP-11322) key based ACL check in KMS always
 check KeyOpType.MANAGEMENT even actual KeyOpType is not MANAGEMENT
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Dian Fu created HADOOP-11322:
--------------------------------

             Summary: key based ACL check in KMS always check KeyOpType.MANAGEMENT even actual KeyOpType is not MANAGEMENT 
                 Key: HADOOP-11322
                 URL: https://issues.apache.org/jira/browse/HADOOP-11322
             Project: Hadoop Common
          Issue Type: Bug
          Components: security
            Reporter: Dian Fu
            Assignee: Dian Fu


In the method checkAccess of class KeyAuthorizationKeyProvider, there is following code:
{code}
private void checkAccess(String aclName, UserGroupInformation ugi,
      KeyOpType opType) throws AuthorizationException {
    Preconditions.checkNotNull(aclName, "Key ACL name cannot be null");
    Preconditions.checkNotNull(ugi, "UserGroupInformation cannot be null");
    if (acls.isACLPresent(aclName, KeyOpType.MANAGEMENT) &&
        (acls.hasAccessToKey(aclName, ugi, opType)
            || acls.hasAccessToKey(aclName, ugi, KeyOpType.ALL))) {
      return;
    }
...
}
{code}
Seems that {code}
acls.isACLPresent(aclName, KeyOpType.MANAGEMENT) {code}
should be replaced with {code}
acls.isACLPresent(aclName, opType) {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)