hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yongjun Zhang <yzh...@cloudera.com>
Subject Re: a friendly suggestion for developers when uploading patches
Date Sat, 22 Nov 2014 19:45:51 GMT
Hi Ted,

Thanks for sharing, this is a good tool to view the patch.

For those who haven't tried: once you install it, then when you mouse-click
on an uploaded patch in Chrome, Chrome will render the patch as if you are
diffing the patch against the base side by side, with left side showing the
base, and right side showing ALL the code change made by the patch, on ONE
screen.

I sometimes just apply the patch to the code base, and use git difftool to
view, but this way I can only view one file at a time, so I have to click
again and again to go through each file changed.

--Yongjun

On Sat, Nov 22, 2014 at 11:04 AM, Ted Yu <yuzhihong@gmail.com> wrote:

> For patch viewing, David Deng has a Chrome extension for rendering patch on
> JIRA.
> See this thread:
> http://search-hadoop.com/m/DHED4LHEYI
>
> FYI
>
> On Sat, Nov 22, 2014 at 10:24 AM, Steve Loughran <stevel@hortonworks.com>
> wrote:
>
> > can we do HADOOP-1111-001.patch
> >
> > with the 001 being the revision.
> >
> > -That numbering scheme guarantees listing order in directories &c
> > -having .patch come after ensures that those people who have .patch bound
> > in their browser to a text editor (e.g. textmate) can view the patch with
> > ease
> >
> > I know having a 3 digit number is pessimistic -I've never got past 70+,
> but
> > you never know
> >
> > For anyone doing patches off their own repo, I'd recommend tagging the
> > commit with the same revision number —but that 's just a personal choice
> >
> >
> >
> > On 21 November 2014 at 19:10, Ted Yu <yuzhihong@gmail.com> wrote:
> >
> > > bq. include a revision number in the patch file name
> > >
> > > +1
> > >
> > > On Fri, Nov 21, 2014 at 11:06 AM, Yongjun Zhang <yzhang@cloudera.com>
> > > wrote:
> > >
> > > > Hi,
> > > >
> > > > When I look at patches uploaded to jiras, from time to time I notice
> > that
> > > > different revisions of the patch is uploaded with the same patch file
> > > name,
> > > > some time for quite a few times. It's confusing which is which.
> > > >
> > > > I'd suggest that as a guideline, we do the following when uploading a
> > > > patch:
> > > >
> > > >    - include a revision number in the patch file name.A
> > > >    - include a comment, stating that a new patch is uploaded,
> including
> > > the
> > > >    revision number of the patch in the comment.
> > > >
> > > > This way, it's easier to refer to a specific version of a patch, and
> to
> > > > know which patch a comment is made about.
> > > >
> > > > Hope that makes sense to you.
> > > >
> > > > Thanks.
> > > >
> > > > --Yongjun
> > > >
> > >
> >
> > --
> > CONFIDENTIALITY NOTICE
> > NOTICE: This message is intended for the use of the individual or entity
> to
> > which it is addressed and may contain information that is confidential,
> > privileged and exempt from disclosure under applicable law. If the reader
> > of this message is not the intended recipient, you are hereby notified
> that
> > any printing, copying, dissemination, distribution, disclosure or
> > forwarding of this communication is strictly prohibited. If you have
> > received this communication in error, please contact the sender
> immediately
> > and delete it from your system. Thank You.
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message