Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-dev@hadoop.apache.org
Received-SPF: pass (nike.apache.org: domain of andrew.wang@cloudera.com
 designates 209.85.220.172 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CADoiZqqE=g_2my14q1McJNgPZkLg6eP=rqMB4PV9caR3zsDZ8w@mail.gmail.com>
References: 
 <CADoiZqpTa5PY7EUO3Mjy8394s2hLEcEgvK3xK_-2BgRfc2UCYQ@mail.gmail.com>
 <CALte62xSfFKOxk+sBHVcg3G2-gQg+sxUXOmdmLMpmZ9aH2cZ-A@mail.gmail.com>
 <CADoiZqon+_Zwd2ySAV+4FKxw+brkmW4Nvg=8=FMU=7CgQe-nSg@mail.gmail.com>
 <CADoiZqp6CWPOmJ=a_EPo6hPqw3UtURm7=LvSFS_KfZYwvHLpoQ@mail.gmail.com>
 <CALte62zyE-ftixcDVMckvNBtw7wkF1+WnScgYjXazt4gnBzLkw@mail.gmail.com>
 <CADoiZqqE=g_2my14q1McJNgPZkLg6eP=rqMB4PV9caR3zsDZ8w@mail.gmail.com>
From: Andrew Wang <andrew.wang@cloudera.com>
Date: Mon, 28 Jul 2014 14:29:37 -0700
Message-ID: 
 <CAGB5D2a94yEotT_tjYw-HxMWvygqEL_1WHcQa+VWxffqDMvWeQ@mail.gmail.com>
Subject: Re: Jenkins problem or patch problem?
To: "common-dev@hadoop.apache.org" <common-dev@hadoop.apache.org>
Content-Type: multipart/alternative; boundary=001a11c2d2beed962804ff479f02

--001a11c2d2beed962804ff479f02
Content-Type: text/plain; charset=UTF-8

I had the same issue on HDFS-6696, patch generated with "git diff
--binary". I ended up making the same patch without the binary part and it
could be applied okay.

This does differ in behavior from the old boxes, which were still able to
apply the non-binary parts of a binary-diff.


On Mon, Jul 28, 2014 at 3:06 AM, Niels Basjes <Niels@basjes.nl> wrote:

> For my test case I needed a something.txt.gz file
> However for this specific test this file will never be actually read, it
> just has to be there and it must be a few bytes in size.
> Because binary files do't work I simply created a file containging "Hello
> world"
> Now this isn't a gzip file at all, yet for my test it does enough to make
> the test work as intended.
>
> So in fact I didn't solve the binary attachment problem at all.
>
>
> On Mon, Jul 28, 2014 at 1:40 AM, Ted Yu <yuzhihong@gmail.com> wrote:
>
> > Mind telling us how you included the binary file in your svn patch ?
> >
> > Thanks
> >
> >
> > On Sun, Jul 27, 2014 at 12:27 PM, Niels Basjes <Niels@basjes.nl> wrote:
> >
> > > I created a patch file with SVN and it works now.
> > > I dare to ask: Are there any git created patch files that work?
> > >
> > >
> > > On Sun, Jul 27, 2014 at 9:44 PM, Niels Basjes <Niels@basjes.nl> wrote:
> > >
> > > > I'll look for a workaround regarding the binary file. Thanks.
> > > >
> > > >
> > > > On Sun, Jul 27, 2014 at 9:07 PM, Ted Yu <yuzhihong@gmail.com> wrote:
> > > >
> > > >> Similar problem has been observed for HBase patches.
> > > >>
> > > >> Have you tried attaching level 1 patch ?
> > > >> For the binary file, to my knowledge, 'git apply' is able to handle
> it
> > > but
> > > >> hadoop is currently using svn.
> > > >>
> > > >> Cheers
> > > >>
> > > >>
> > > >> On Sun, Jul 27, 2014 at 11:01 AM, Niels Basjes <Niels@basjes.nl>
> > wrote:
> > > >>
> > > >> > Hi,
> > > >> >
> > > >> > I just submitted a patch and Jenkins said it failed to apply the
> > > patch.
> > > >> > But when I look at the console output
> > > >> >
> > > >> >
> > https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4771//console
> > > >> >
> > > >> > it says:
> > > >> >
> > > >> > At revision 1613826.
> > > >> > MAPREDUCE-2094 patch is being downloaded at Sun Jul 27 18:50:44
> UTC
> > > >> > 2014 fromhttp://
> > > >> >
> > > >>
> > >
> >
> issues.apache.org/jira/secure/attachment/12658034/MAPREDUCE-2094-20140727.patch*cp
> > > >> > :
> > > >> > cannot stat '/home/jenkins/buildSupport/lib/*': No such file or
> > > >> > directory
> > > >> > *The patch does not appear to apply with p0 to p2
> > > >> > PATCH APPLICATION FAILED
> > > >> >
> > > >> >
> > > >> > Now I do have a binary file (for the unit test) in this patch,
> > > perhaps I
> > > >> > did something wrong? Or is this problem caused by the error I
> > > >> highlighted?
> > > >> >
> > > >> > What can I do to fix this?
> > > >> >
> > > >> > --
> > > >> > Best regards / Met vriendelijke groeten,
> > > >> >
> > > >> > Niels Basjes
> > > >> >
> > > >>
> > > >
> > > >
> > > >
> > > > --
> > > > Best regards / Met vriendelijke groeten,
> > > >
> > > > Niels Basjes
> > > >
> > >
> > >
> > >
> > > --
> > > Best regards / Met vriendelijke groeten,
> > >
> > > Niels Basjes
> > >
> >
>
>
>
> --
> Best regards / Met vriendelijke groeten,
>
> Niels Basjes
>

--001a11c2d2beed962804ff479f02--