hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HADOOP-6278) Update HowToCommit with clear list of Committer responsibilities
Date Thu, 24 Jul 2014 00:30:42 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Allen Wittenauer resolved HADOOP-6278.
--------------------------------------

    Resolution: Won't Fix

Closing this as won't fix.

Do we really need a *jira* to update the *wiki*?

> Update HowToCommit with clear list of Committer responsibilities
> ----------------------------------------------------------------
>
>                 Key: HADOOP-6278
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6278
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: documentation
>    Affects Versions: site
>            Reporter: Nigel Daley
>            Priority: Critical
>
> http://wiki.apache.org/hadoop/HowToCommit should be updated to clearly spell out these
committer responsibilities:
> 1) For non-trivial patches, code reviews must be done by another *committer*.
> 2) Code reviews follow the checklist (http://wiki.apache.org/hadoop/CodeReviewChecklist)
so that, among other things, the patch is checked for robust documentation and unit tests

> 3) A -1 from Hadoop QA for lack of unit tests *must* be explained satisfactorily by the
contributor else the patch *is not* committed. In this case, the manual tests performed by
the contributor must be explained.
> 4) A -1 from Hadoop QA for findbugs, javadoc, or javac warnings means the patch *must
not* be committed until these are fixed (else every subsequent patch will get -1 on these)
> 5) A -1 from Hadoop QA for core *and* contrib unit tests means the patch *must not* be
committed until these are fixed (else every subsequent patch will get -1 on these)
> Others responsibilities?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message