Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-dev@hadoop.apache.org
Received-SPF: pass (athena.apache.org: domain of hubaghdadi@gmail.com
 designates 209.85.223.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CALwhT94eFZXANaLU2NpqsmLKD4KaXrbTxtpQMR2NuE1fnxQD8g@mail.gmail.com>
References: 
 <CAJ7WdqVRoVE6ECJiO6RocyuG+kH6hHgaCoVwMD468RgrwAu=RA@mail.gmail.com>
 <CALwhT94eFZXANaLU2NpqsmLKD4KaXrbTxtpQMR2NuE1fnxQD8g@mail.gmail.com>
From: Hussein Baghdadi <hubaghdadi@gmail.com>
Date: Wed, 19 Mar 2014 21:39:03 +0100
Message-ID: 
 <CAJ7WdqXTvoZhQ2VvA9XvRc-6jeaOmPF0podPc=RLwhcBfW-y1A@mail.gmail.com>
Subject: Re: Fixing MAPREDUCE-5748
To: common-dev <common-dev@hadoop.apache.org>
Content-Type: multipart/alternative; boundary=001a11c31f7412ed6704f4fba72c

--001a11c31f7412ed6704f4fba72c
Content-Type: text/plain; charset=ISO-8859-1

Hi Karthik,

I submitted the patch to
https://issues.apache.org/jira/browse/MAPREDUCE-5748

I followed http://wiki.apache.org/hadoop/HowToContribute

Thank you.

Best,
Hussein.


On Wed, Mar 19, 2014 at 9:33 PM, Karthik Kambatla <kasha@cloudera.com>wrote:

> Hey Hussein
>
> Thanks for picking MAPREDUCE-5748 up. Can you post the patch on the JIRA,
> and we can continue the conversation there?
>
> Thanks
> Karthik
>
>
> On Wed, Mar 19, 2014 at 12:55 PM, Hussein Baghdadi <hubaghdadi@gmail.com
> >wrote:
>
> > Hi,
> >
> > I tried to fix MAPREDUCE-5748
> >
> > What I did is to add another condition in addition to checking for nulls.
> > I'm checking whether mapIds is empty or not
> >
> > if (mapIds == null || mapIds.size() == 0 || reduceQ == null || jobQ ==
> > null)
> >
> > I also created a unit test where 'map' param is missing. I'm not sure
> > about the quality of the unit test but I tried my best.
> >
> > Here in the email, you can find a patch file.
> >
> > Thanks for help and time.
> >
> > Best,
> > Hussein.
> >
> > --
> >
> > *Deep into that darkness peering, long I stood there, wondering, fearing,
> > doubting, dreaming dreams no mortal ever dared to dream before. Edgar
> Allan
> > Poe*
> >
>


-- 

*Deep into that darkness peering, long I stood there, wondering, fearing,
doubting, dreaming dreams no mortal ever dared to dream before.Edgar Allan
Poe*

--001a11c31f7412ed6704f4fba72c--