Return-Path: X-Original-To: apmail-hadoop-common-dev-archive@www.apache.org Delivered-To: apmail-hadoop-common-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9D18F106AC for ; Mon, 6 Jan 2014 23:03:55 +0000 (UTC) Received: (qmail 79833 invoked by uid 500); 6 Jan 2014 23:03:53 -0000 Delivered-To: apmail-hadoop-common-dev-archive@hadoop.apache.org Received: (qmail 79460 invoked by uid 500); 6 Jan 2014 23:03:52 -0000 Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-dev@hadoop.apache.org Delivered-To: mailing list common-dev@hadoop.apache.org Received: (qmail 79444 invoked by uid 99); 6 Jan 2014 23:03:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Jan 2014 23:03:52 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of tucu@cloudera.com designates 209.85.128.49 as permitted sender) Received: from [209.85.128.49] (HELO mail-qe0-f49.google.com) (209.85.128.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Jan 2014 23:03:48 +0000 Received: by mail-qe0-f49.google.com with SMTP id w7so19084748qeb.36 for ; Mon, 06 Jan 2014 15:03:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=frPkLXl6tYLWFiFoDUxl9/XzvXtegnmb+7UfsUZj51o=; b=ZalYMPMSyVrfu0vReVXwqf6gSWm0NnjVKluoVQHN2nthHJLmBiETq8xfT7+AvrJDpf QFE6t9rliItov0cLknWrAD+5ox6NF/mlnM+1gK33yOvW5+vq7HjJaKVDc5BQYueVc1/N 5ib0MMLuhF1XzTYq4naikM2KR503bYwawbZsyfBoDXOInmS8+F6t/Uuq4Ufs4/IvvoIt D1KgzCegg5Xr7gsaUOQaOa0YhyTGtJ+77DbAIOXKTmMbdFMsw8EDva9hWaWixnyv469v FLUtk1x7fdfCzJ75kuCVBz/1r3HoGDhTJrkVGTKYCKjwmgl0FDIuIlh5MPHQwBGdOJHU paJw== X-Gm-Message-State: ALoCoQkPNu6zHXp8cxMIcHh4dFUhUM0sx/URR/u7pEFFT7BmrDTJ64p+5d66HDKTkkxpE3QLPLUZ X-Received: by 10.229.102.4 with SMTP id e4mr181409645qco.2.1389049407912; Mon, 06 Jan 2014 15:03:27 -0800 (PST) MIME-Version: 1.0 Received: by 10.96.196.164 with HTTP; Mon, 6 Jan 2014 15:02:57 -0800 (PST) In-Reply-To: References: From: Alejandro Abdelnur Date: Mon, 6 Jan 2014 15:02:57 -0800 Message-ID: Subject: Re: [Discussion] Merge YARN-321 into Branch-2 To: "yarn-dev@hadoop.apache.org" Cc: "common-dev@hadoop.apache.org" Content-Type: multipart/alternative; boundary=001a1133ba2c88f48104ef554447 X-Virus-Checked: Checked by ClamAV on apache.org --001a1133ba2c88f48104ef554447 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable This is great news. A few things to consider before doing the merge: 1* The merge must be done in trunk first (then, ideally, from trunk into branch-2) 2* The last update of YARN-321 was done in NOV10, this was done from branch-2 (that seems a NIT as it should be against trunk) 3* IMO, until we don=92t have security, we should merge into trunk only I would like to see #1 and #2 taken care before making a decision. The reason for this is that if the source changes outside of the AHS are too pervasive, then we may end up be making difficult backports from trunk to branch-2 and release branches because of the delta. Can we get a rebase of the YARN-321 to the head of trunk to see if my concerns are valid or not? Thanks. Alejandro On Mon, Jan 6, 2014 at 1:11 AM, Sandy Ryza wrote: > Very excited for this feature and appreciative of all the work put into > this. Reviewed the JIRA and my only two remaining concerns are about > documentation and API stability. > > Regarding doc, while we don't necessarily need full documentation before > merging, my feeling is that we should at least have a page on it that wil= l > allow give cluster operators a sketch of its role, APIs, and implications= . > If this doesn't exist yet, would be happy to help with reviewing. > > Regarding APIs, I imagine some will jump on this as soon as it becomes pa= rt > of a release as it's a fairly essential feature for non-MR apps. My > opinion is that we should mark each API @Stable unless there is a strong > reason for it not to be. When I say APIs, I am thinking of the REST APIs= , > RPC interface, and RM<->AHS shared-bus. > > -Sandy > > > On Sun, Jan 5, 2014 at 8:33 PM, lohit wrote: > > > +1 to merge into branch2 now. > > On Jan 5, 2014 6:22 PM, "Zhijie Shen" wrote: > > > > > Hi folks, > > > > > > Majority of the functionality of Application History Server has been > > > completed on branch YARN-321. AHS can now work end-to-end. > > ResourceManager > > > records the historical information of the application, the applicatio= n > > > attempt and the container in terms of events via a history writer on = a > > > separate thread. The historical information is going to be persisted = on > > > HDFS. On the other side, an application history server runs as a > separate > > > process, and it allows users to access the historical information via > RPC > > > interface, web UI and REST APIs. > > > > > > According to the proposal, the only major missing piece is security. > > Except > > > it, YARN-321 should be pretty much ready to be merged to Branch-2. We > > > propose to merge YARN-321 to Branch-2 now, such that we can prevent > > > YARN-321 from falling behind too much, and reduce the effort of editi= ng > > > merge conflicts. After merge, we can continue on security, refactorin= g > > > duplicate code, fixing bugs and other improvements. > > > > > > Anyone who is interested in looking at AHS can review/play with > YARN-321 > > > branch: http://svn.apache.org/viewvc/hadoop/common/branches/YARN-321/ > > > > > > You can also have a look at the latest design doc: > > > > > > > > > https://issues.apache.org/jira/secure/attachment/12619638/Generic%20Appli= cation%20History%20-%20Design-20131219.pdf > > > > > > If there are no objections, we'll push towards updating the branch, > > running > > > the patch through Jenkins and getting ready for merge vote by the end > of > > > this week. > > > > > > Thanks, > > > Zhijie > > > > > > -- > > > Zhijie Shen > > > Hortonworks Inc. > > > http://hortonworks.com/ > > > > > > -- > > > CONFIDENTIALITY NOTICE > > > NOTICE: This message is intended for the use of the individual or > entity > > to > > > which it is addressed and may contain information that is confidentia= l, > > > privileged and exempt from disclosure under applicable law. If the > reader > > > of this message is not the intended recipient, you are hereby notifie= d > > that > > > any printing, copying, dissemination, distribution, disclosure or > > > forwarding of this communication is strictly prohibited. If you have > > > received this communication in error, please contact the sender > > immediately > > > and delete it from your system. Thank You. > > > > > > --=20 Alejandro --001a1133ba2c88f48104ef554447--