hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HADOOP-6565) AbstractDelegationTokenSecretManager.stopThreads() will NPE if called before startThreads()
Date Wed, 07 Aug 2013 16:17:50 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-6565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jason Lowe resolved HADOOP-6565.
--------------------------------

    Resolution: Duplicate

Dup of HADOOP-6554, ultimately fixed by HADOOP-6573.
                
> AbstractDelegationTokenSecretManager.stopThreads() will NPE if called before startThreads()
> -------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-6565
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6565
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Steve Loughran
>            Priority: Minor
>
> Looking at the code for starting/stopping SecretManagers, it seems to me that {{AbstractDelegationTokenSecretManager.stopThreads()}}
assumes that {{tokenRemoverThread}} is never null. That assumption is only valid if {{AbstractDelegationTokenSecretManager.startThreads()}}
was called first.
> the call to {{tokenRemoverThread.interrupt()}} should be guarded with a check for {{tokenRemoverThread!=null}}
> I haven't encountered this in the field yet, but it should be trivial to replicate in
a test and then fix.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message