hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HADOOP-9719) Branch-1-win TestFsShellReturnCode#testChgrp() failed caused by incorrect exit codes
Date Thu, 11 Jul 2013 00:03:48 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-9719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Chris Nauroth resolved HADOOP-9719.

      Resolution: Fixed
    Hadoop Flags: Reviewed

+1 for the patch.  I committed this to branch-1-win.  Thank you again, Xi!
> Branch-1-win TestFsShellReturnCode#testChgrp() failed caused by incorrect exit codes
> ------------------------------------------------------------------------------------
>                 Key: HADOOP-9719
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9719
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 1-win
>            Reporter: Xi Fang
>            Assignee: Xi Fang
>            Priority: Minor
>              Labels: test
>             Fix For: 1-win
>         Attachments: HADOOP-9719.patch
> TestFsShellReturnCode#testChgrp() failed when we try to use "-chgrp" to change group
association of files to "admin".
> {code}
> // Test 1: exit code for chgrp on existing file is 0
>     String argv[] = { "-chgrp", "admin", f1 };
>     verify(fs, "-chgrp", argv, 1, fsShell, 0);
> {code}
> On Windows, this is the error information:
> org.apache.hadoop.util.Shell$ExitCodeException: GetSidFromAcctName error (1332): No mapping
between account names and security IDs was done.
> Invalid group name: admin
> This test case passed previously, but it looks like this test case incorrectly passed
because of another bug in FsShell@runCmdHandler (https://issues.apache.org/jira/browse/HADOOP-9502).
The original code in FsShell#runCmdHandler may not return error exit codes for some exceptions
(see private static int runCmdHandler(CmdHandler handler, FileStatus stat, FileSystem srcFs,
boolean recursive) throws IOException {}). Therefore, in previous Branch-1-win if even if
admin is not a valid group, there is no error caught. The fix of HADOOP-9502 makes this test
> This test also failed on Linux

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message