Return-Path: X-Original-To: apmail-hadoop-common-dev-archive@www.apache.org Delivered-To: apmail-hadoop-common-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 674D8E5DF for ; Thu, 21 Feb 2013 10:28:40 +0000 (UTC) Received: (qmail 8562 invoked by uid 500); 21 Feb 2013 10:28:37 -0000 Delivered-To: apmail-hadoop-common-dev-archive@hadoop.apache.org Received: (qmail 8022 invoked by uid 500); 21 Feb 2013 10:28:37 -0000 Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-dev@hadoop.apache.org Delivered-To: mailing list common-dev@hadoop.apache.org Received: (qmail 7873 invoked by uid 99); 21 Feb 2013 10:28:36 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Feb 2013 10:28:36 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of stevel@hortonworks.com designates 209.85.216.42 as permitted sender) Received: from [209.85.216.42] (HELO mail-qa0-f42.google.com) (209.85.216.42) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Feb 2013 10:28:29 +0000 Received: by mail-qa0-f42.google.com with SMTP id cr7so2913914qab.15 for ; Thu, 21 Feb 2013 02:28:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=IlWjHcDGiW+Lj/xs3L18ZBv//SOPr888yyN+ZcnURbE=; b=RT5963U2eyNLnThE9qP2D/Ehpf2YqcMe/ol1BOnBEJFr05avdYCxOQLiiIKp7+uMK6 7GtmTE5bZa8j+Oa8wMbClx4Z/lqUv4bdMMHzpUvqHm8IQEH81jOuoESKhIlmJpyLcIQu Oh7PpB+BBXZLSZtT201q9tpKJ7sj7b9qX2VRhvmMOFX9e0KfhHjXFEJEKumnIReXppuH jaCrZqYClNTJAWHDOlR6gKrozSQAk6YZ7p8gJOz3t8XOp+qETG2F6XgkdAH61m96y5V4 dxU+vkk6g8QgLl2nLaklQ/Tpaux57t/QCykdVcnxzYheOfv1UV89YhBrzao08o9TIxHW SeQg== MIME-Version: 1.0 X-Received: by 10.49.74.10 with SMTP id p10mr11494829qev.35.1361442488592; Thu, 21 Feb 2013 02:28:08 -0800 (PST) Received: by 10.49.1.229 with HTTP; Thu, 21 Feb 2013 02:28:08 -0800 (PST) In-Reply-To: References: Date: Thu, 21 Feb 2013 10:28:08 +0000 Message-ID: Subject: Re: timeout is now requested to be on all tests From: Steve Loughran To: hdfs-dev@hadoop.apache.org Cc: "mapreduce-dev@hadoop.apache.org" , "yarn-dev@hadoop.apache.org" , "common-dev@hadoop.apache.org" Content-Type: multipart/alternative; boundary=047d7bdc1272ea29d004d6398777 X-Gm-Message-State: ALoCoQk3YSGHw3zJ5V/ErOl1LcSNaWYwDaj/e6gkBidoTpLkY/jx56mi8HkNLeCLW0bv5XEwGNNY X-Virus-Checked: Checked by ClamAV on apache.org --047d7bdc1272ea29d004d6398777 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable thanks, just seen and commented on this. IF we're going to have test timeouts, we need a good recommended default value for all tests except the extra slow ones. Or 1. we just use our own JUnit fork that sets up a better default value than 0. I don't know how Ken would react to that. 2. we get maven sure to support a programmable (default) timeout for every test case. This is probably easier, and would work for all existing tests too. Has anyone asked the Maven team about options here? On 20 February 2013 16:46, Robert Evans wrote: > Sorry about cross posting, but this will impact all developers and I > wanted to give you all a heads-up. > > HADOOP-9112 was just > checked it. This means that the pre commit build will now give a =E2=80= =931 for > any patch with junit tests that do not include a timeout option. See > http://junit.sourceforge.net/javadoc/org/junit/Test.html for more info on > that. This is to avoid surefire timing out junit when it gets stuck and > not giving any real feedback on which test failed. > > --Bobby > --047d7bdc1272ea29d004d6398777--