Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-dev@hadoop.apache.org
Received-SPF: pass (athena.apache.org: domain of suren.k.n@me.com designates
 17.172.124.248 as permitted sender)
Content-type: text/plain; charset=windows-1252
MIME-version: 1.0 (Mac OS X Mail 6.2 \(1499\))
Subject: Re: timeout is now requested to be on all tests
From: Surenkumar Nihalani <suren.k.n@me.com>
In-reply-to: 
 <CA+4kjVsBOR7wUN5-j00Jh7fMProwk3LbG6OYVh=AH6Pm9+RShg@mail.gmail.com>
Date: Thu, 21 Feb 2013 11:38:57 -0500
Cc: hdfs-dev@hadoop.apache.org,
 "yarn-dev@hadoop.apache.org" <yarn-dev@hadoop.apache.org>,
 "common-dev@hadoop.apache.org" <common-dev@hadoop.apache.org>
Content-transfer-encoding: quoted-printable
Message-id: <470A10E6-3DF7-4C4C-A417-FD9D196F8866@me.com>
References: <CD4A59FE.6577%evans@yahoo-inc.com>
 <CA+4kjVsBOR7wUN5-j00Jh7fMProwk3LbG6OYVh=AH6Pm9+RShg@mail.gmail.com>
To: mapreduce-dev@hadoop.apache.org

Just wanted to give everyone a heads up. Due to this change, I have =
introduced a bug.=20

It's returning opposite value of what it's supposed to.=20
So, +1 of all tests you change brings up a -1 overall and vice versa.=20

I have reopened HADOOP-9112 and uploaded the patch to reverse to reverse =
to the correct return values. Once a committer goes ahead with, it will =
be corrected.

Sorry about the inconvenience.=20

Thanks,
Surenkumar Nihalani.

On Feb 21, 2013, at 5:28 AM, Steve Loughran <stevel@hortonworks.com> =
wrote:

> thanks, just seen and commented on this.
>=20
> IF we're going to have test timeouts, we need a good recommended =
default
> value for all tests except the extra slow ones.
>=20
> Or
> 1. we just use our own JUnit fork that sets up a better default value =
than
> 0. I don't know how Ken would react to that.
> 2. we get maven sure to support a programmable (default) timeout for =
every
> test case. This is probably easier, and would work for all existing =
tests
> too.
>=20
> Has anyone asked the Maven team about options here?
>=20
> On 20 February 2013 16:46, Robert Evans <evans@yahoo-inc.com> wrote:
>=20
>> Sorry about cross posting, but this will impact all developers and I
>> wanted to give you all a heads-up.
>>=20
>> HADOOP-9112<https://issues.apache.org/jira/browse/HADOOP-9112> was =
just
>> checked it.  This means that the pre commit build will now give a =961 =
for
>> any patch with junit tests that do not include a timeout option.  See
>> http://junit.sourceforge.net/javadoc/org/junit/Test.html for more =
info on
>> that.  This is to avoid surefire timing out junit when it gets stuck =
and
>> not giving any real feedback on which test failed.
>>=20
>> --Bobby
>>=20