Return-Path: X-Original-To: apmail-hadoop-common-dev-archive@www.apache.org Delivered-To: apmail-hadoop-common-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 85D55E4F2 for ; Tue, 18 Dec 2012 16:42:31 +0000 (UTC) Received: (qmail 7168 invoked by uid 500); 18 Dec 2012 16:42:29 -0000 Delivered-To: apmail-hadoop-common-dev-archive@hadoop.apache.org Received: (qmail 7054 invoked by uid 500); 18 Dec 2012 16:42:29 -0000 Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-dev@hadoop.apache.org Delivered-To: mailing list common-dev@hadoop.apache.org Received: (qmail 7042 invoked by uid 99); 18 Dec 2012 16:42:28 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Dec 2012 16:42:28 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of stevel@hortonworks.com designates 209.85.216.47 as permitted sender) Received: from [209.85.216.47] (HELO mail-qa0-f47.google.com) (209.85.216.47) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Dec 2012 16:42:21 +0000 Received: by mail-qa0-f47.google.com with SMTP id a19so3486662qad.20 for ; Tue, 18 Dec 2012 08:42:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:x-gm-message-state; bh=/2h7au7AiX6CGeNJH7B/UljCRYE/jxY/JTLMeJW7voc=; b=pSg9P+4/CYN3DzhbrquUPt781oE55w/C1A3Ipgr9m/hf3cDk97OeBVKjIFWQS64o5A eyJl4NJ4NM06WYrYRPNj7Ar/nn5nF9v5+GL0PCopY3KV58nZvrJeY/rpcR/PqkIa4X7B ogR+dswNL8YEzb3H+vuUS12my57ccXPt1N/j6c1yXqOrFtfzTqjgam8tPiwr8Y8IeR6r 9FQo+sZapKZvNTwOjNR5c/pd+PUdChQA8lnggmu8uZN0jAm3UCQ+THy5HuI2xd4D8tTH zWGdvcrprGhXRhjZQPmeJKvuH8wte/r0oS9InkqROYpwwESitMKkisqL83ejxySenn5e nefw== MIME-Version: 1.0 Received: by 10.224.35.137 with SMTP id p9mr1114923qad.85.1355848920714; Tue, 18 Dec 2012 08:42:00 -0800 (PST) Received: by 10.49.47.81 with HTTP; Tue, 18 Dec 2012 08:42:00 -0800 (PST) In-Reply-To: References: Date: Tue, 18 Dec 2012 16:42:00 +0000 Message-ID: Subject: Re: making a hadoop-common test run if a property is set From: Steve Loughran To: common-dev@hadoop.apache.org Content-Type: multipart/alternative; boundary=20cf3074b44a49cd7d04d1232d79 X-Gm-Message-State: ALoCoQknu9GSo6KfoB0GudQYL7lmH5srrvdrtZ/WEQsScOozK81P/e8RbO/a3I1PtAxk49JVdFFh X-Virus-Checked: Checked by ClamAV on apache.org --20cf3074b44a49cd7d04d1232d79 Content-Type: text/plain; charset=UTF-8 On 17 December 2012 16:06, Tom White wrote: > There are some tests like the S3 tests that end with "Test" (e.g. > Jets3tNativeS3FileSystemContractTest) - unlike normal tests which > start with "Test". Only those that start with "Test" are run > automatically (see the surefire configuration in > hadoop-project/pom.xml). You have to run the others manually with "mvn > test -Dtest=...". > > thinking some more (especially, how to make subclasses of FileSystemContractTestBase optional without patching that base class), we could add public static suite() methods to the child classes and have them skip all the tests if they are optional. I haven't abused the suite() method for a while; it used to be the only way to do parameterized tests, but in theory this should work -though there's the maintenance overhead of keeping the list of test methods to return up to date --20cf3074b44a49cd7d04d1232d79--