Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-dev@hadoop.apache.org
Received-SPF: pass (athena.apache.org: domain of yhemanth@gmail.com designates
 74.125.82.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CC6B6310.79BA%evans@yahoo-inc.com>
References: 
 <CA++OR+pCmzDg+sWtCF4B_HEa53KO-FK-4NtE32_rD-sMb=Annw@mail.gmail.com>
	<CC6B6310.79BA%evans@yahoo-inc.com>
Date: Wed, 5 Sep 2012 10:18:16 +0530
Message-ID: 
 <CA++OR+rmY-uOjEeEspDjofjSwcugcLE+x=CGOzAYbTozYpdx5g@mail.gmail.com>
Subject: Re: Unused API in LocalDirAllocator
From: Hemanth Yamijala <yhemanth@gmail.com>
To: common-dev@hadoop.apache.org
Content-Type: text/plain; charset=ISO-8859-1

Thanks. Filed https://issues.apache.org/jira/browse/HADOOP-8765.

Hemanth

On Tue, Sep 4, 2012 at 6:22 PM, Robert Evans <evans@yahoo-inc.com> wrote:
> I don't think it really matters that much.  The API is limited Private and
> unstable, so I would say just remove it, but fixing it is fine too.
> Either way file a JIRA on it.
>
> --Bobby
>
> On 9/4/12 6:34 AM, "Hemanth Yamijala" <yhemanth@gmail.com> wrote:
>
>>Hi,
>>
>>Stumbled on the fact that LocalDirAllocator.ifExists() is not used
>>anywhere. The previous usage of this API was in the IsolationRunner
>>that was removed in MAPREDUCE-2606.
>>
>>This API doesn't call the confChanged method and hence there is an
>>uninitialised variable that causes a NullPointerException. So, either
>>we can fix that, or remove the API if it's not required. This is also
>>one of the reasons why the IsolationRunner was broken in 1.0.
>>
>>Thoughts ?
>>
>>Thanks
>>hemanth
>