hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bo Wang (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HADOOP-8750) Configuration.getClasses never returns default value
Date Thu, 30 Aug 2012 23:39:08 GMT
Bo Wang created HADOOP-8750:
-------------------------------

             Summary: Configuration.getClasses never returns default value
                 Key: HADOOP-8750
                 URL: https://issues.apache.org/jira/browse/HADOOP-8750
             Project: Hadoop Common
          Issue Type: Bug
            Reporter: Bo Wang
            Assignee: Bo Wang


getClasses method in Configuration never returns defaultValue even if the classnames is not
set in Configuration.

public Class<?>[] getClasses(String name, Class<?> ... defaultValue) {
    String[] classnames = getTrimmedStrings(name);
    if (classnames == null)
      return defaultValue;
    // Load and return classes using classnames... (omitted)
  }

This is because the condition "if (classnames == null)" is always True. If name is not set
in Configuration, classnames will be an empty array (but not null).

To fix it, just change the condition to "if (classnames == null || classnames.length == 0)"



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message