hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From madhu phatak <phatak....@gmail.com>
Subject Re: Resolving find bug issue
Date Wed, 27 Jun 2012 07:22:23 GMT
Hi Robert,
 Thanks for your input.I have updated the patch with public getter for the

On Tue, Jun 26, 2012 at 7:44 PM, Robert Evans <evans@yahoo-inc.com> wrote:

> The issue you are running into is because you made the HOST variable
> public, when it was package previously.  Findbugs thinks that you want HOST
> to be a constant because it is ALL CAPS and is only set once and read all
> other times.  By making it public it is now difficult to ensure that it is
> never written to, hence the suggestion to make it final.  I would prefer to
> actually switch it over to private and add in a new public method that
> return the value of HOST.
> --Bobby Evans
> On 6/26/12 6:01 AM, "madhu phatak" <phatak.dev@gmail.com> wrote:
> Hi,
>  I have submitted a patch for jira (HADOOP-8521) which is giving findbug(
> https://issues.apache.org/jira/browse/HADOOP-8521) error. To fix the
> issue,I have to duplicate the StreamUtil class to the newly introduced
> mapreduce package.Is it a good practice or is there other way to fix this?
> Regards,
> Madhukara Phatak
> --
> https://github.com/zinnia-phatak-dev/Nectar


  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message