Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-dev@hadoop.apache.org
Date: Wed, 18 Apr 2012 23:02:40 +0000 (UTC)
From: "Colin Patrick McCabe (Created) (JIRA)" <jira@apache.org>
To: common-dev@hadoop.apache.org
Message-ID: 
 <1020866741.3764.1334790160037.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Created] (HADOOP-8291) jenkins: include support for binary
 patches
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

jenkins: include support for binary patches
-------------------------------------------

                 Key: HADOOP-8291
                 URL: https://issues.apache.org/jira/browse/HADOOP-8291
             Project: Hadoop Common
          Issue Type: Improvement
            Reporter: Colin Patrick McCabe
            Priority: Minor


git, as well as the latest version of the GNU patch program, include support for generating binary diffs.  These are diffs between binary files.

If we added support for binary diffs to Jenkins, it would be very useful for testing changes which involve altering a binary file.  Currently these changes are untestable by Jenkins, because binary diffs show up in older patch files like this:

{code}
diff --git hadoop-hdfs-project/hadoop-hdfs/src/test/resources/editsStored hadoop-hdfs-project/hadoop-hdfs/src/test/resources/editsStored
index 5099ce2..75fb82f 100644
Binary files hadoop-hdfs-project/hadoop-hdfs/src/test/resources/editsStored and hadoop-hdfs-project/hadoop-hdfs/src/test/resources/editsStored differ

{code}

As you can see, this has no actual information about what the change was.

However, when using binary diffs (git diff --binary) you get something like this:
{code}
diff --git hadoop-hdfs-project/hadoop-hdfs/src/test/resources/editsStored hadoop-hdfs-project/hadoop-hdfs/src/test/resources/editsStored
index 5099ce21b3026331ccda23d2fe289b6d7b427f69..75fb82ff751954afd796641f467c09e13e3ce0a2 100644
GIT binary patch
delta 60
zcmZpYS}C>RD~|~W0|Zzz@aU&y=A_0a7o{eaqyhyw@>0v)i}Fhg-Us^0i9?myFdlcG
F2msT84>SM(

delta 21
YcmZ1})g-myD-W+Y0|Z#lUwp|306=R6wg3PC

{code}

We should add support for this to Jenkins.  It might be as simple as upgrading the version of GNU patch on the server.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira