From common-dev-return-78246-apmail-hadoop-common-dev-archive=hadoop.apache.org@hadoop.apache.org Tue Apr 3 16:52:21 2012 Return-Path: X-Original-To: apmail-hadoop-common-dev-archive@www.apache.org Delivered-To: apmail-hadoop-common-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8314E9EC9 for ; Tue, 3 Apr 2012 16:52:21 +0000 (UTC) Received: (qmail 78894 invoked by uid 500); 3 Apr 2012 16:52:19 -0000 Delivered-To: apmail-hadoop-common-dev-archive@hadoop.apache.org Received: (qmail 78842 invoked by uid 500); 3 Apr 2012 16:52:19 -0000 Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-dev@hadoop.apache.org Delivered-To: mailing list common-dev@hadoop.apache.org Received: (qmail 78832 invoked by uid 99); 3 Apr 2012 16:52:19 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Apr 2012 16:52:19 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of devaraj.k@huawei.com designates 58.251.152.64 as permitted sender) Received: from [58.251.152.64] (HELO szxga01-in.huawei.com) (58.251.152.64) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Apr 2012 16:52:13 +0000 Received: from huawei.com (szxga05-in [172.24.2.49]) by szxga05-in.huawei.com (iPlanet Messaging Server 5.2 HotFix 2.14 (built Aug 8 2006)) with ESMTP id <0M1W008QWXH3IL@szxga05-in.huawei.com> for common-dev@hadoop.apache.org; Wed, 04 Apr 2012 00:51:03 +0800 (CST) Received: from szxrg01-dlp.huawei.com ([172.24.2.119]) by szxga05-in.huawei.com (iPlanet Messaging Server 5.2 HotFix 2.14 (built Aug 8 2006)) with ESMTP id <0M1W006E6XH2OP@szxga05-in.huawei.com> for common-dev@hadoop.apache.org; Wed, 04 Apr 2012 00:51:03 +0800 (CST) Received: from szxeml211-edg.china.huawei.com ([172.24.2.119]) by szxrg01-dlp.huawei.com (MOS 4.1.9-GA) with ESMTP id AIA30916; Wed, 04 Apr 2012 00:51:02 +0800 Received: from SZXEML406-HUB.china.huawei.com (10.82.67.93) by szxeml211-edg.china.huawei.com (172.24.2.182) with Microsoft SMTP Server (TLS) id 14.1.323.3; Wed, 04 Apr 2012 00:50:46 +0800 Received: from SZXEML524-MBS.china.huawei.com ([169.254.5.155]) by szxeml406-hub.china.huawei.com ([10.82.67.93]) with mapi id 14.01.0323.003; Wed, 04 Apr 2012 00:50:57 +0800 Date: Tue, 03 Apr 2012 16:50:56 +0000 From: Devaraj k Subject: RE: Help a newbie on patch submission In-reply-to: X-Originating-IP: [172.24.1.45] To: "common-dev@hadoop.apache.org" Message-id: <06006DDA5A27D541991944AC4117E7A93F660E98@szxeml524-mbs.china.huawei.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-language: en-US Content-transfer-encoding: 7BIT Accept-Language: en-US, zh-CN Thread-topic: Help a newbie on patch submission Thread-index: Ac0RtCClkKNJbs5VTDqeU050pG9glgABVPPZ X-MS-Has-Attach: X-MS-TNEF-Correlator: X-CFilter-Loop: Reflected References: X-Virus-Checked: Checked by ClamAV on apache.org I tried applying your patches in my environment, It works fine. The issue with Hadoop QA may be because of having -M (^M) characters in the patch file. Can you try by removing the -M (^M) chars in the patch. Thanks Devaraj ________________________________________ From: Mostafa Elhemali [mostafae@microsoft.com] Sent: Tuesday, April 03, 2012 9:42 PM To: common-dev@hadoop.apache.org Subject: Help a newbie on patch submission Hi, I'm trying to submit a patch to fix some build problems in Hadoop trunk on Windows, and I'm having a hard time pleasing Hadoop QA. This is for Hadoop-8241 (https://issues.apache.org/jira/browse/HADOOP-8241). I submitted the first patch and it said it couldn't apply it, so I figured it may have to do with the fact that one of the two files fixed is in hadoop-hdfs-https which isn't part of the Hadoop Common project. So I submitted a second patch just for hadoop-dist/pom.xml which I believe is part of the Common project, but that couldn't be applied as well. So I come to you: what am I doing horribly wrong and how can I appease the almighty Hadoop QA? Thanks, Mostafa Elhemali