hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alejandro Abdelnur <t...@cloudera.com>
Subject Re: JIRA attachments order
Date Fri, 09 Sep 2011 18:16:37 GMT
Agreed.  Furthermore, if I have 10+ versions of a patch, when getting
feedback knowing for with version would be handy, having a single name makes
this correlation difficult.

Thxs.

Alejandro
[PS: I know, I should code better not have to go thru several versions]

On Fri, Sep 9, 2011 at 11:08 AM, Ravi Prakash <ravihadoop@gmail.com> wrote:

> But what if I want to see an incremental diff between two patches? I don't
> want to review the whole patch everytime. Maybe I just want to re-review
> the
> changes made to a patch. I would then have sort the patches manually using
> time. I think its better to have version numbers in that case
>
>
> On Fri, Sep 9, 2011 at 10:48 AM, Doug Cutting <cutting@apache.org> wrote:
>
> > On 09/09/2011 07:27 AM, Ted Dunning wrote:
> > > If you post the same patch with the same name, JIRA helps you out by
> > greying
> > > all the earlier versions out.
> >
> > Indeed.  That's the best practice, not to add version numbers to patch
> > files, for this very reason.  We should perhaps note this on:
> >
> > http://wiki.apache.org/hadoop/HowToContribute
> >
> > I am a Jira administrator and would be happy to change the default
> > ordering of attachments if it were possible, however I can see no option
> > to do so.
> >
> > Doug
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message