Return-Path: X-Original-To: apmail-hadoop-common-dev-archive@www.apache.org Delivered-To: apmail-hadoop-common-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8E24F6B38 for ; Thu, 16 Jun 2011 12:13:33 +0000 (UTC) Received: (qmail 32705 invoked by uid 500); 16 Jun 2011 12:13:32 -0000 Delivered-To: apmail-hadoop-common-dev-archive@hadoop.apache.org Received: (qmail 32569 invoked by uid 500); 16 Jun 2011 12:13:32 -0000 Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-dev@hadoop.apache.org Delivered-To: mailing list common-dev@hadoop.apache.org Received: (qmail 32554 invoked by uid 99); 16 Jun 2011 12:13:32 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Jun 2011 12:13:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 24D681C01AF; Thu, 16 Jun 2011 12:13:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6055688372025100276==" MIME-Version: 1.0 Subject: Re: Review Request: HADOOP-7328. Improve the SerializationFactory functions. From: "Harsh J" To: "Todd Lipcon" Date: Thu, 16 Jun 2011 12:13:34 -0000 Message-ID: <20110616121334.13642.4478@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/884/ Cc: "hadoop-common" , "Harsh J" , "Matt Foley" In-Reply-To: <20110611221017.30868.10017@reviews.apache.org> References: <20110611221017.30868.10017@reviews.apache.org> --===============6055688372025100276== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/884/ ----------------------------------------------------------- (Updated 2011-06-16 12:13:34.081758) Review request for hadoop-common and Todd Lipcon. Changes ------- Throw exceptions (getting rid of nulls). Add appropriate javadocs and fix o= ne checkstyle nit. Summary ------- Since getSerialization() can possibly return a null, it is only right that = getSerializer() and getDeserializer() usage functions do the same, instead = of throwing up NPEs. Related issue to which this improvement is required: https://issues.apache.= org/jira/browse/MAPREDUCE-2584 This addresses bug HADOOP-7328. http://issues.apache.org/jira/browse/HADOOP-7328 Diffs (updated) ----- src/java/org/apache/hadoop/io/serializer/SerializationFactory.java dee314= a = Diff: https://reviews.apache.org/r/884/diff Testing ------- Existing SequenceFile serialization factory tests pass. The change is merel= y to make the functions return null instead of throwing an NPE within. Thanks, Harsh --===============6055688372025100276==--