Return-Path: X-Original-To: apmail-hadoop-common-dev-archive@www.apache.org Delivered-To: apmail-hadoop-common-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 520FA47D2 for ; Sun, 12 Jun 2011 04:43:36 +0000 (UTC) Received: (qmail 29746 invoked by uid 500); 12 Jun 2011 04:43:34 -0000 Delivered-To: apmail-hadoop-common-dev-archive@hadoop.apache.org Received: (qmail 29651 invoked by uid 500); 12 Jun 2011 04:43:34 -0000 Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-dev@hadoop.apache.org Delivered-To: mailing list common-dev@hadoop.apache.org Received: (qmail 29620 invoked by uid 99); 12 Jun 2011 04:43:33 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Jun 2011 04:43:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7C1811C0066; Sun, 12 Jun 2011 04:43:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7797107762480486680==" MIME-Version: 1.0 Subject: Re: Review Request: HADOOP-7328. Improve the SerializationFactory functions. From: "Harsh J" To: "Todd Lipcon" Date: Sun, 12 Jun 2011 04:43:35 -0000 Message-ID: <20110612044335.30868.75136@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/884/ Cc: "Harsh J" , "hadoop-common" In-Reply-To: <20110612022455.30868.16827@reviews.apache.org> References: <20110612022455.30868.16827@reviews.apache.org> --===============7797107762480486680== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2011-06-12 02:24:55, Todd Lipcon wrote: > > Looks good to me. Can you upload this rev of the patch to the JIRA so t= he QA Bot runs on it? Submitted on JIRA. Thanks for the review Todd! - Harsh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/884/#review805 ----------------------------------------------------------- On 2011-06-11 22:10:17, Harsh J wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/884/ > ----------------------------------------------------------- > = > (Updated 2011-06-11 22:10:17) > = > = > Review request for hadoop-common and Todd Lipcon. > = > = > Summary > ------- > = > Since getSerialization() can possibly return a null, it is only right tha= t getSerializer() and getDeserializer() usage functions do the same, instea= d of throwing up NPEs. > = > Related issue to which this improvement is required: https://issues.apach= e.org/jira/browse/MAPREDUCE-2584 > = > = > This addresses bug HADOOP-7328. > http://issues.apache.org/jira/browse/HADOOP-7328 > = > = > Diffs > ----- > = > src/java/org/apache/hadoop/io/serializer/SerializationFactory.java dee3= 14a = > = > Diff: https://reviews.apache.org/r/884/diff > = > = > Testing > ------- > = > Existing SequenceFile serialization factory tests pass. The change is mer= ely to make the functions return null instead of throwing an NPE within. > = > = > Thanks, > = > Harsh > = > --===============7797107762480486680==--