Return-Path: X-Original-To: apmail-hadoop-common-dev-archive@www.apache.org Delivered-To: apmail-hadoop-common-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 08B796E63 for ; Tue, 7 Jun 2011 17:22:32 +0000 (UTC) Received: (qmail 81417 invoked by uid 500); 7 Jun 2011 17:22:30 -0000 Delivered-To: apmail-hadoop-common-dev-archive@hadoop.apache.org Received: (qmail 81368 invoked by uid 500); 7 Jun 2011 17:22:30 -0000 Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-dev@hadoop.apache.org Delivered-To: mailing list common-dev@hadoop.apache.org Delivered-To: moderator for common-dev@hadoop.apache.org Received: (qmail 34221 invoked by uid 99); 7 Jun 2011 14:51:35 -0000 Content-Type: multipart/alternative; boundary="===============5608736857793723361==" MIME-Version: 1.0 Subject: Re: Review Request: HADOOP-7314 Add support for throwing UnknownHostException when a host doesn't resolve From: "Tom Graves" To: "Tom Graves" , "Jeffrey Naisbitt" , "hadoop-mapreduce" , "hadoop-common" Date: Tue, 07 Jun 2011 14:51:37 -0000 Message-ID: <20110607145137.30869.87370@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/775/ In-Reply-To: <20110523154939.29375.53509@reviews.apache.org> References: <20110523154939.29375.53509@reviews.apache.org> --===============5608736857793723361== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/775/#review775 ----------------------------------------------------------- Ship it! +1 Looks good. - Tom On 2011-05-23 15:49:39, Jeffrey Naisbitt wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/775/ > ----------------------------------------------------------- > = > (Updated 2011-05-23 15:49:39) > = > = > Review request for hadoop-common and hadoop-mapreduce. > = > = > Summary > ------- > = > As part of MAPREDUCE-2489, we need support for having the resolve methods= (for DNS mapping) throw UnknownHostExceptions. (Currently, they hide the e= xception). Since the existing 'resolve' method is ultimately used by severa= l other locations/components, I propose we add a new 'resolveValidHosts' me= thod. > = > = > This addresses bug HADOOP-7314. > https://issues.apache.org/jira/browse/HADOOP-7314 > = > = > Diffs > ----- > = > trunk/src/java/org/apache/hadoop/net/DNSToSwitchMapping.java 1125067 = > trunk/src/java/org/apache/hadoop/net/ScriptBasedMapping.java 1125067 = > trunk/src/test/core/org/apache/hadoop/net/StaticMapping.java 1125067 = > trunk/src/test/core/org/apache/hadoop/net/TestScriptBasedMapping.java 1= 125067 = > trunk/src/java/org/apache/hadoop/net/CachedDNSToSwitchMapping.java 1125= 067 = > = > Diff: https://reviews.apache.org/r/775/diff > = > = > Testing > ------- > = > = > Thanks, > = > Jeffrey > = > --===============5608736857793723361==--