Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-dev@hadoop.apache.org
Date: Sun, 26 Jun 2011 05:19:47 +0000 (UTC)
From: "Aaron T. Myers (JIRA)" <jira@apache.org>
To: common-dev@hadoop.apache.org
Message-ID: 
 <1877230590.41108.1309065587934.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <669810108.8410.1297360857966.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Resolved] (HADOOP-7135) Commit 949660 broke
 FileUtil.copyMerge
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HADOOP-7135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron T. Myers resolved HADOOP-7135.
------------------------------------

    Resolution: Invalid
      Assignee: Jim Plush

Thanks a lot for the investigation, Jim. Closing this out.

> Commit 949660 broke FileUtil.copyMerge
> --------------------------------------
>
>                 Key: HADOOP-7135
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7135
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.21.0
>            Reporter: Jeffrey Gerard
>            Assignee: Jim Plush
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> Looking at http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.21/src/java/org/apache/hadoop/fs/FileUtil.java?r1=949659&r2=949660&
> it seems this commit broke FileUtil.copyMerge by omitting NOT operator.  copyMerge only makes sense if srcDir is a directory.
> Should be
>     if (!srcFS.getFileStatus(srcDir).isDirectory())
>        return false;

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira