hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon" <t...@apache.org>
Subject Re: Review Request: HADOOP-7328. Improve the SerializationFactory functions.
Date Sun, 12 Jun 2011 02:24:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/884/#review805
-----------------------------------------------------------

Ship it!


Looks good to me. Can you upload this rev of the patch to the JIRA so the QA Bot runs on it?

- Todd


On 2011-06-11 22:10:17, Harsh Chouraria wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/884/
> -----------------------------------------------------------
> 
> (Updated 2011-06-11 22:10:17)
> 
> 
> Review request for hadoop-common and Todd Lipcon.
> 
> 
> Summary
> -------
> 
> Since getSerialization() can possibly return a null, it is only right that getSerializer()
and getDeserializer() usage functions do the same, instead of throwing up NPEs.
> 
> Related issue to which this improvement is required: https://issues.apache.org/jira/browse/MAPREDUCE-2584
> 
> 
> This addresses bug HADOOP-7328.
>     http://issues.apache.org/jira/browse/HADOOP-7328
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/hadoop/io/serializer/SerializationFactory.java dee314a 
> 
> Diff: https://reviews.apache.org/r/884/diff
> 
> 
> Testing
> -------
> 
> Existing SequenceFile serialization factory tests pass. The change is merely to make
the functions return null instead of throwing an NPE within.
> 
> 
> Thanks,
> 
> Harsh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message