Return-Path: Delivered-To: apmail-hadoop-common-dev-archive@www.apache.org Received: (qmail 36353 invoked from network); 17 Jan 2011 09:00:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 17 Jan 2011 09:00:47 -0000 Received: (qmail 65461 invoked by uid 500); 17 Jan 2011 09:00:46 -0000 Delivered-To: apmail-hadoop-common-dev-archive@hadoop.apache.org Received: (qmail 64918 invoked by uid 500); 17 Jan 2011 09:00:43 -0000 Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-dev@hadoop.apache.org Delivered-To: mailing list common-dev@hadoop.apache.org Received: (qmail 64898 invoked by uid 99); 17 Jan 2011 09:00:43 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Jan 2011 09:00:43 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=10.0 tests=ALL_TRUSTED,FREEMAIL_FROM,HTML_MESSAGE X-Spam-Check-By: apache.org Received: from [140.211.11.40] (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Jan 2011 09:00:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (8.14.3/8.14.3/Debian-9.1ubuntu1) with ESMTP id p0H90Jri010281; Mon, 17 Jan 2011 09:00:19 GMT Content-Type: multipart/alternative; boundary="===============3339072388472825660==" MIME-Version: 1.0 Subject: Review Request: MAPREDUCE-2254 Allow setting of end-of-record delimiter for TextInputFormat From: "Ahmed Radwan" To: "Ahmed Radwan" , "hadoop-mapreduce" , "hadoop-common" Date: Mon, 17 Jan 2011 09:00:19 -0000 Message-ID: <20110117090019.3760.20500@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/329/ X-Virus-Checked: Checked by ClamAV on apache.org --===============3339072388472825660== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/329/ ----------------------------------------------------------- Review request for hadoop-common and hadoop-mapreduce. Summary ------- This patch allows users to specify custom end-of-record delimiter for TextI= nputFormat using a new added configuration property. For backward compatibi= lity, if this new configuration property is absent, then the same exact pre= vious delimiters are used (i.e., '\n', '\r' or '\r\n'). See also HADOOP-709= 6. This addresses bug MAPREDUCE-2254. http://issues.apache.org/jira/browse/MAPREDUCE-2254 Diffs ----- src/java/org/apache/hadoop/mapreduce/lib/input/LineRecordReader.java bb15= b1d = src/java/org/apache/hadoop/mapreduce/lib/input/TextInputFormat.java fb0f6= 31 = src/test/mapred/org/apache/hadoop/mapreduce/lib/input/TestLineRecordReade= r.java PRE-CREATION = Diff: https://reviews.apache.org/r/329/diff Testing ------- Current tests pass. Added a new test case. Thanks, Ahmed --===============3339072388472825660==--