hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ahmed Radwan" <a.aboel...@gmail.com>
Subject Review Request: MAPREDUCE-2254 Allow setting of end-of-record delimiter for TextInputFormat
Date Mon, 17 Jan 2011 09:00:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/329/
-----------------------------------------------------------

Review request for hadoop-common and hadoop-mapreduce.


Summary
-------

This patch allows users to specify custom end-of-record delimiter for TextInputFormat using
a new added configuration property. For backward compatibility, if this new configuration
property is absent, then the same exact previous delimiters are used (i.e., '\n', '\r' or
'\r\n'). See also HADOOP-7096.


This addresses bug MAPREDUCE-2254.
    http://issues.apache.org/jira/browse/MAPREDUCE-2254


Diffs
-----

  src/java/org/apache/hadoop/mapreduce/lib/input/LineRecordReader.java bb15b1d 
  src/java/org/apache/hadoop/mapreduce/lib/input/TextInputFormat.java fb0f631 
  src/test/mapred/org/apache/hadoop/mapreduce/lib/input/TestLineRecordReader.java PRE-CREATION


Diff: https://reviews.apache.org/r/329/diff


Testing
-------

Current tests pass. Added a new test case.


Thanks,

Ahmed


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message