hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Todd Lipcon <t...@cloudera.com>
Subject Re: What is the correct spelling?
Date Mon, 27 Dec 2010 20:41:41 GMT
Hi Niels,

Yep, I'd say for something like that it's fine t fix the spelling as part of
another patch that touches those functions.

-Todd

On Mon, Dec 27, 2010 at 1:18 AM, Niels Basjes <Niels@basjes.nl> wrote:

> Hi Todd,
>
> > Unfortunately this is part of a public facing API, so it's a bit tough to
> > change without breaking a bunch of dependent code. So, I think despite
> the
> > annoying spelling mistake, it's not worth the pain to fix because of the
> API
> > breakage :(
>
> Yes, I fully agree. Changing public APIs is a monster.
>
> > If you find other spelling mistakes that are parts of internal APIs, feel
> > free to file JIRAs and patches to fix!
>
> The changes I was thinking about are limited to the junit testing
> files for the codecs. --> fully internal
>
> Specifically this one:
>
> http://svn.apache.org/viewvc/hadoop/common/trunk/src/test/core/org/apache/hadoop/io/compress/TestCodec.java?view=markup
>
> Which contains (among others) this method: testSplitableCodecs
>
> As I'm actually touching these methods I'll include the changes in the
> patch I'm currently working on.
>
> --
> Met vriendelijke groeten,
>
> Niels Basjes
>



-- 
Todd Lipcon
Software Engineer, Cloudera

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message