hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik" <...@apache.org>
Subject Re: Review Request: Add copyBytes method to Text and BytesWritable to improve usability
Date Thu, 16 Dec 2010 16:41:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/182/#review73
-----------------------------------------------------------

Ship it!


- Konstantin


On 2010-12-16 05:35:58, Owen O'Malley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/182/
> -----------------------------------------------------------
> 
> (Updated 2010-12-16 05:35:58)
> 
> 
> Review request for hadoop-common.
> 
> 
> Summary
> -------
> 
> Users would like a method that returned byte arrays of precisely the right length, even
if it requires a data copy.
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/HADOOP-6298.
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/HADOOP-6298
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/io/BytesWritable.java
1049968 
>   http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/io/Text.java
1049968 
>   http://svn.apache.org/repos/asf/hadoop/common/trunk/src/test/core/org/apache/hadoop/io/TestBytesWritable.java
1049968 
>   http://svn.apache.org/repos/asf/hadoop/common/trunk/src/test/core/org/apache/hadoop/io/TestText.java
1049968 
> 
> Diff: https://reviews.apache.org/r/182/diff
> 
> 
> Testing
> -------
> 
> Added unit tests and passed Hudson
> 
> 
> Thanks,
> 
> Owen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message