Return-Path: Delivered-To: apmail-hadoop-common-dev-archive@www.apache.org Received: (qmail 50519 invoked from network); 2 Nov 2010 20:32:09 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 2 Nov 2010 20:32:09 -0000 Received: (qmail 78927 invoked by uid 500); 2 Nov 2010 20:32:39 -0000 Delivered-To: apmail-hadoop-common-dev-archive@hadoop.apache.org Received: (qmail 78882 invoked by uid 500); 2 Nov 2010 20:32:38 -0000 Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-dev@hadoop.apache.org Delivered-To: mailing list common-dev@hadoop.apache.org Received: (qmail 78872 invoked by uid 99); 2 Nov 2010 20:32:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Nov 2010 20:32:38 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=10.0 tests=ALL_TRUSTED,HTML_MESSAGE X-Spam-Check-By: apache.org Received: from [140.211.11.40] (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Nov 2010 20:32:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (8.14.3/8.14.3/Debian-9.1ubuntu1) with ESMTP id oA2KWoDp003286; Tue, 2 Nov 2010 20:32:50 GMT Content-Type: multipart/alternative; boundary="===============9109974156035693920==" MIME-Version: 1.0 Subject: Re: Review Request: Allow configuration changes without restarting configured nodes From: "Patrick Kling" To: "Todd Lipcon" , "Patrick Kling" , "hadoop-common" Date: Tue, 02 Nov 2010 20:32:50 -0000 Message-ID: <20101102203250.28430.73518@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/21/ In-Reply-To: <20101102033123.28431.80578@reviews.apache.org> References: <20101102033123.28431.80578@reviews.apache.org> --===============9109974156035693920== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21/ ----------------------------------------------------------- (Updated 2010-11-02 13:32:50.159119) Review request for hadoop-common. Changes ------- Incorporated Todd's comments. Thank you! - Added unit tests for ReconfigurationUtil.getChangedProperties, Reconfigur= able interface methods and cross-thread visibility of configuration changes. - Added proper escaping to servlet. - Removed synchronization from Configuration methods that were already prot= ected by synchronization of getProps(). In this revision, I have only added= synchronization to the setter methods. - Changed getReconfigurableProperties to return Collection rather than List. - Fixed typo. - Removed commented-out code. - Removed unnecessary imports. Summary ------- Allow configuration changes without restarting configured nodes This addresses bug HADOOP-7001. https://issues.apache.org/jira/browse/HADOOP-7001 Diffs (updated) ----- http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/h= adoop/conf/Configuration.java 1026174 = http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/h= adoop/conf/Reconfigurable.java PRE-CREATION = http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/h= adoop/conf/ReconfigurableBase.java PRE-CREATION = http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/h= adoop/conf/ReconfigurationException.java PRE-CREATION = http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/h= adoop/conf/ReconfigurationServlet.java PRE-CREATION = http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/h= adoop/conf/ReconfigurationUtil.java PRE-CREATION = http://svn.apache.org/repos/asf/hadoop/common/trunk/src/test/core/org/apa= che/hadoop/conf/TestReconfiguration.java PRE-CREATION = Diff: https://reviews.apache.org/r/21/diff Testing ------- Manual testing with Reconfigurable NameNode from https://issues.apache.org/= jira/browse/HDFS-1477 Thanks, Patrick --===============9109974156035693920==--