Return-Path: 
 <common-dev-return-74465-apmail-hadoop-common-dev-archive=hadoop.apache.org@hadoop.apache.org>
Delivered-To: apmail-hadoop-common-dev-archive@www.apache.org
Received: (qmail 77929 invoked from network); 2 Nov 2010 04:34:02 -0000
Received: from unknown (HELO mail.apache.org) (140.211.11.3)
  by 140.211.11.9 with SMTP; 2 Nov 2010 04:34:02 -0000
Received: (qmail 48356 invoked by uid 500); 2 Nov 2010 04:34:32 -0000
Delivered-To: apmail-hadoop-common-dev-archive@hadoop.apache.org
Received: (qmail 48036 invoked by uid 500); 2 Nov 2010 04:34:32 -0000
Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:common-dev-help@hadoop.apache.org>
List-Unsubscribe: <mailto:common-dev-unsubscribe@hadoop.apache.org>
List-Post: <mailto:common-dev@hadoop.apache.org>
List-Id: <common-dev.hadoop.apache.org>
Reply-To: common-dev@hadoop.apache.org
Delivered-To: mailing list common-dev@hadoop.apache.org
Delivered-To: moderator for common-dev@hadoop.apache.org
Received: (qmail 44010 invoked by uid 99); 2 Nov 2010 04:28:18 -0000
X-ASF-Spam-Status: No, hits=-1997.8 required=10.0
	tests=ALL_TRUSTED,HTML_MESSAGE
X-Spam-Check-By: apache.org
Content-Type: multipart/alternative;
	boundary="===============5574595586931685194=="
MIME-Version: 1.0
Subject: Re: Review Request: Allow configuration changes without restarting
 configured nodes
From: "Todd Lipcon" <todd@apache.org>
To: "Todd Lipcon" <todd@apache.org>, "Patrick Kling" <pkling@cs.uwaterloo.ca>,
        "hadoop-common" <common-dev@hadoop.apache.org>
Date: Tue, 02 Nov 2010 04:28:28 -0000
Message-ID: <20101102042828.28430.80264@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
X-ReviewRequest-URL: https://reviews.apache.org/r/21/
In-Reply-To: <20101102033123.28431.80578@reviews.apache.org>
References: <20101102033123.28431.80578@reviews.apache.org>

--===============5574595586931685194==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21/#review22
-----------------------------------------------------------


I'm not so sure about making all of the Configuration methods synchronized.=
 For one in terms of deadlock possibility, for two in terms of performance.=
 Is this really necessary?


http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/had=
oop/conf/Reconfigurable.java
<https://reviews.apache.org/r/21/#comment11>

    typo: a the



http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/had=
oop/conf/Reconfigurable.java
<https://reviews.apache.org/r/21/#comment12>

    Collection<String> seems more general



http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/had=
oop/conf/ReconfigurationServlet.java
<https://reviews.apache.org/r/21/#comment13>

    why commented out?



http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/had=
oop/conf/ReconfigurationServlet.java
<https://reviews.apache.org/r/21/#comment14>

    need escaping on all interpolated values throughout



http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/had=
oop/conf/ReconfigurationUtil.java
<https://reviews.apache.org/r/21/#comment15>

    this could be unit tested


- Todd


On 2010-11-01 20:31:22, Patrick Kling wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21/
> -----------------------------------------------------------
> =

> (Updated 2010-11-01 20:31:22)
> =

> =

> Review request for hadoop-common.
> =

> =

> Summary
> -------
> =

> Allow configuration changes without restarting configured nodes
> =

> =

> This addresses bug HADOOP-7001.
>     https://issues.apache.org/jira/browse/HADOOP-7001
> =

> =

> Diffs
> -----
> =

>   http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache=
/hadoop/conf/Configuration.java 1026174 =

>   http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache=
/hadoop/conf/Reconfigurable.java PRE-CREATION =

>   http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache=
/hadoop/conf/ReconfigurableBase.java PRE-CREATION =

>   http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache=
/hadoop/conf/ReconfigurationException.java PRE-CREATION =

>   http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache=
/hadoop/conf/ReconfigurationServlet.java PRE-CREATION =

>   http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache=
/hadoop/conf/ReconfigurationUtil.java PRE-CREATION =

> =

> Diff: https://reviews.apache.org/r/21/diff
> =

> =

> Testing
> -------
> =

> Manual testing with Reconfigurable NameNode from https://issues.apache.or=
g/jira/browse/HDFS-1477
> =

> =

> Thanks,
> =

> Patrick
> =

>


--===============5574595586931685194==--