hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Kling" <pkl...@cs.uwaterloo.ca>
Subject Re: Review Request: Add listCorruptFileBlocks to FileSystem
Date Fri, 19 Nov 2010 04:07:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49/
-----------------------------------------------------------

(Updated 2010-11-18 20:07:20.147948)


Review request for hadoop-common.


Changes
-------

Added listCorruptFileBlocks to FileContext.
Changed FilterFileSystem to call underlying filesystem's listCorruptFileBlocks.


Summary
-------

Add listCorruptFileBlocks to FileSystem API. Throw UnsupportedOperationException for FileSystems
that don't support this.


This addresses bug HADOOP-7023.
    https://issues.apache.org/jira/browse/HADOOP-7023


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/AbstractFileSystem.java
1036663 
  http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/CorruptFileBlocks.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileContext.java
1036663 
  http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileSystem.java
1036663 
  http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/FilterFileSystem.java
1036663 

Diff: https://reviews.apache.org/r/49/diff


Testing
-------

ant test passes

ant test-patch output:

     [exec] -1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified
tests.
     [exec]                         Please justify why no new tests are needed for this patch.
     [exec]                         Also please list what manual steps were performed to verify
this patch.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec]
     [exec]     -1 findbugs.  The patch appears to introduce 2 new Findbugs warnings.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
     [exec]
     [exec]     +1 system test framework.  The patch passed system test framework compile.

Note: unit tests for this are included with HDFS-1482.
This patch does not actually introduce any new findbugs warnings (see MAPREDUCE-2172 for why
they show up here).


Thanks,

Patrick


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message