hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Todd Lipcon <t...@cloudera.com>
Subject Re: [DISCUSSION]: Integrating SureLogic into Hadoop
Date Mon, 10 May 2010 23:42:53 GMT
Great, thanks for checking with SureLogic, Cos! I absolutely agree
that hudson QAbot tests are critical for keeping the number of
warnings low (or 0!)

-Todd

2010/5/10 Konstantin Boudnik <cos@yahoo-inc.com>:
> This is very valid concern Todd. I am talking with SureLogic at the moment to
> find out if they will be willing to provide the license to all Hadoop
> contributors.
>
> On the other hand not including such type of validation into standard patch
> validation process poses a danger of code degradation as time passes. E.g. we
> can add SureLogic validation into secondary build but then Hadoop committers
> will have to make sure that no new SureLogic's warnings were added in the
> last week or so and fix them immediately or at least open a JIRA to track such
> issues. Certainly there some other ways.
>
> I believe we might need to make an effort here to help SureLogic to limit the
> distribution of the license by Hadoop contributors crowd. I am not sure if this is
> Ok to ask contributors to fill some kind of legal form where they agree not to
> use the copy of the license for any projects not hosted by ASF or something?
> Similar to what we fill for our the contributions to ASF? But first let's hear
> SureLogic take on the license ;)
>
> Cos
>
> On Fri, May 07, 2010 at 04:35PM, Todd Lipcon wrote:
>> Hi Cos,
>>
>> This looks great, and I'm excited to have more ways of finding these tricky
>> bugs. Are there any examples of bugs found already by these techniques?
>>
>> The one concern I have about the proposal is with this:
>> > SureLogic analysis is going to be included to the test-patch process. This
>> said new patches are required not to raise SureLogic warnings level (similar
>> to the requirements about FindBugs or javac).
>>
>> This is slightly worrisome since the SureLogic license is only available to
>> committers. For non-committers, I think this may prove to be difficult since
>> they won't have any local means of checking for warnings and verifying that
>> they've fixed them.
>>
>> Thanks
>> -Todd
>>
>>
>> 2010/5/5 Konstantin Boudnik <cos@yahoo-inc.com>
>>
>> > Hello.
>> >
>> > As some of you might know we have the license for great concurrency
>> > analysis
>> > software from SureLogic.
>> >
>> > SureLogic engineers gave some run for HDFS, MR, and Zookeeper code at the
>> > end
>> > of last year. The tools seem very promising and supposedly bring us the
>> > value (linked from the page below).
>> >
>> > Please read this Wiki page to get more information about the tool and to
>> > get some understanding how it works
>> >  http://wiki.apache.org/hadoop/HowToUseConcurrencyAnalysisTools
>> >
>> > Here's the additional information on how to install/upgrade to the latest
>> > release: http://surelogic.com/static/eclipse/install.html
>> >
>> > There's also a couple of JIRAs w/ patches (HDFS-801, MAPREDUCE-1259) to
>> > integrate annotations into our current source code base. The annotations
>> > are
>> > represented as a jar file with some interface classes. They are
>> > redistributed
>> > under Apache license. The retention policy of annotations are 'compile
>> > time',
>> > i.e. this jar isn't required for the runtime of Hadoop.
>> >
>> > It'd be great to hear community thoughts on this so we can make some
>> > decision
>> > about this toolset.
>> >
>> > Please comment. Thanks
>> >  Cos
>> >
>>
>>
>>
>> --
>> Todd Lipcon
>> Software Engineer, Cloudera
>



-- 
Todd Lipcon
Software Engineer, Cloudera

Mime
View raw message