hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eli Collins <...@cloudera.com>
Subject Re: HADOOP-6704 - getResource() usage ok?
Date Fri, 30 Apr 2010 22:55:57 GMT
Just attach a the newer version.  You can see the most recent patch
based on the date however most people just append a number
(hadoop-6704-2.patch etc)  to indicate the patch is newer.

Thanks,
Eli

On Fri, Apr 30, 2010 at 3:45 PM, Neil Bliss <neilbliss@gmail.com> wrote:
> For subsequent patch submissions, should I first remove the earlier patch
> from the Jira, or just attach the newer revision?
>
> thanks,
>
> Neil
>
> On Fri, Apr 30, 2010 at 3:40 PM, Neil Bliss <neilbliss@gmail.com> wrote:
>
>> Found the problem, I had an overly helpful local CLASSPATH set.
>>
>>
>> On Fri, Apr 30, 2010 at 1:22 PM, Neil Bliss <neilbliss@gmail.com> wrote:
>>
>>> Thanks Eli, I'll have a look how the other instances are used, and see if
>>> I can spot the problem.
>>>
>>> - Neil
>>>
>>>
>>> On Fri, Apr 30, 2010 at 1:17 PM, Eli Collins <eli@cloudera.com> wrote:
>>>
>>>> Hey Neil,
>>>>
>>>> There are other uses of getResource in Hadoop so should be fine.
>>>> Should you be using getClassLoader#getResource() instead of
>>>> Class#getResource()?
>>>>
>>>> Thanks,
>>>> Eli
>>>>
>>>> On Fri, Apr 30, 2010 at 12:46 PM, Neil Bliss <neil@neilbliss.com> wrote:
>>>> > Hey folks,
>>>> >
>>>> > In the unit tests for my HADOOP-6704 patch, I'm using getResource()
to
>>>> get
>>>> > the URL of a sample xml file.  On my local system this works fine,
but
>>>> when
>>>> > I submitted the patch to Hudson, it appears to not find the resource
>>>> file.
>>>> >  Is this sort of thing not allowed in the Hudson environment, or am
I
>>>> just
>>>> > doing something wrong?
>>>> >
>>>> > I've already fixed up the checkstyle errors that I missed the first
>>>> time
>>>> > around.  Gomen nasai.
>>>> >
>>>> > thanks,
>>>> >
>>>> > Neil
>>>> >
>>>>
>>>
>>>
>>
>

Mime
View raw message