Return-Path: Delivered-To: apmail-hadoop-common-dev-archive@www.apache.org Received: (qmail 17339 invoked from network); 12 Mar 2010 10:02:26 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 12 Mar 2010 10:02:26 -0000 Received: (qmail 89745 invoked by uid 500); 12 Mar 2010 10:01:49 -0000 Delivered-To: apmail-hadoop-common-dev-archive@hadoop.apache.org Received: (qmail 89511 invoked by uid 500); 12 Mar 2010 10:01:49 -0000 Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-dev@hadoop.apache.org Delivered-To: mailing list common-dev@hadoop.apache.org Received: (qmail 89503 invoked by uid 99); 12 Mar 2010 10:01:48 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Mar 2010 10:01:48 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Mar 2010 10:01:47 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 3B199234C4C1 for ; Fri, 12 Mar 2010 10:01:27 +0000 (UTC) Message-ID: <1233778547.224051268388087240.JavaMail.jira@brutus.apache.org> Date: Fri, 12 Mar 2010 10:01:27 +0000 (UTC) From: "Vinod K V (JIRA)" To: common-dev@hadoop.apache.org Subject: [jira] Created: (HADOOP-6631) FileUtil.fullyDelete() should continue to delete other files despite failure at any level. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 FileUtil.fullyDelete() should continue to delete other files despite failure at any level. ------------------------------------------------------------------------------------------ Key: HADOOP-6631 URL: https://issues.apache.org/jira/browse/HADOOP-6631 Project: Hadoop Common Issue Type: Bug Components: fs, util Reporter: Vinod K V Fix For: 0.22.0 Ravi commented about this on HADOOP-6536. Paraphrasing... Currently FileUtil.fullyDelete(myDir) comes out stopping deletion of other files/directories if it is unable to delete a file/dir(say because of not having permissions to delete that file/dir) anywhere under myDir. This is because we return from method if the recursive call "if(!fullyDelete()) {return false;}" fails at any level of recursion. Shouldn't it continue with deletion of other files/dirs continuing in the for loop instead of returning false here ? I guess fullyDelete() should delete as many files as possible(similar to 'rm -rf'). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.